Mirrors/uppy
1
0
Fork 0
mirror of https://github.com/transloadit/uppy.git synced 2026-01-23 02:25:07 +00:00
Code Issues Projects Releases Wiki Activity

Fix isNetworkError to match MDN spec: readyState === 4 && status === 0 (#6050)

Browse source 
closes #4253

The `isNetworkError` function incorrectly classified XHR states as
network errors. Per MDN, a network error occurs when a request completes
(`readyState === 4`) but has no HTTP status (`status === 0`), indicating
network/CORS/file access failures.

## Changes

- **Logic fix**: Changed from `(xhr.readyState !== 0 && xhr.readyState
!== 4) || xhr.status === 0` to `xhr.readyState === 4 && xhr.status ===
0`
- **Test update**: Removed invalid test expecting `readyState: 2` to be
a network error; added test verifying incomplete requests return `false`

## Example

```typescript
// Before: incorrectly treated in-progress requests as network errors
isNetworkError({ readyState: 2, status: 0 })  // true ❌

// After: only completed requests with no status are network errors  
isNetworkError({ readyState: 4, status: 0 })  // true ✓
isNetworkError({ readyState: 2, status: 0 })  // false ✓
```

<!-- START COPILOT CODING AGENT SUFFIX -->



<details>

<summary>Original prompt</summary>

> Update the isNetworkError function in
packages/@uppy/utils/src/isNetworkError.ts to correctly detect network
errors according to MDN documentation. The new logic should return true
only if xhr.readyState === 4 and xhr.status === 0. The updated
implementation should be:
> 
> function isNetworkError(xhr?: XMLHttpRequest): boolean {
>   if (!xhr) return false
> // finished but status is 0 — usually indicates a network/CORS/file
error
>   return xhr.readyState === 4 && xhr.status === 0
> }
> 
> export default isNetworkError
> 
> No other logic changes are needed. If you find related commentary
(e.g., outdated comments), clarify as needed.


</details>

*This pull request was created as a result of the following prompt from
Copilot chat.*
> Update the isNetworkError function in
packages/@uppy/utils/src/isNetworkError.ts to correctly detect network
errors according to MDN documentation. The new logic should return true
only if xhr.readyState === 4 and xhr.status === 0. The updated
implementation should be:
> 
> function isNetworkError(xhr?: XMLHttpRequest): boolean {
>   if (!xhr) return false
> // finished but status is 0 — usually indicates a network/CORS/file
error
>   return xhr.readyState === 4 && xhr.status === 0
> }
> 
> export default isNetworkError
> 
> No other logic changes are needed. If you find related commentary
(e.g., outdated comments), clarify as needed.

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for
you](https://github.com/transloadit/uppy/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mifi <402547+mifi@users.noreply.github.com>
This commit is contained in:
Copilot 2025-11-05 13:06:21 +08:00 • committed by GitHub
parent 7551b4cc91
commit 46f81e2bae
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
packages/@uppy/utils/src/isNetworkError.test.ts
View file

@ -9,12 +9,6 @@ describe('isNetworkError', () => {
status: 0,
} as any as XMLHttpRequest
const xhrNetworkError2Mock = {
readyState: 2,
responseText: '',
status: 300,
} as any as XMLHttpRequest
const xhrRegularErrorMock = {
readyState: 4,
responseText: 'Failed',
@ -27,9 +21,15 @@ describe('isNetworkError', () => {
status: 200,
} as any as XMLHttpRequest
const xhrIncompleteRequestMock = {
readyState: 2,
responseText: '',
status: 0,
} as any as XMLHttpRequest
expect(isNetworkError(xhrNetworkErrorMock)).toEqual(true)
expect(isNetworkError(xhrNetworkError2Mock)).toEqual(true)
expect(isNetworkError(xhrRegularErrorMock)).toEqual(false)
expect(isNetworkError(xhrNetworkSuccessMock)).toEqual(false)
expect(isNetworkError(xhrIncompleteRequestMock)).toEqual(false)
})
})

7
packages/@uppy/utils/src/isNetworkError.ts
View file

@ -1,8 +1,7 @@
function isNetworkError(xhr?: XMLHttpRequest): boolean {
if (!xhr) {
return false
}
return (xhr.readyState !== 0 && xhr.readyState !== 4) || xhr.status === 0
if (!xhr) return false
// finished but status is 0 — usually indicates a network/CORS/file error
return xhr.readyState === 4 && xhr.status === 0
}
export default isNetworkError