From 44fe7f1654a070561bafdb3b949e15af578ef8a2 Mon Sep 17 00:00:00 2001 From: Ifedapo Olarewaju Date: Thu, 13 Jun 2019 14:17:16 +0100 Subject: [PATCH] companion: don't log uppyAuthToken --- packages/@uppy/companion/src/standalone/index.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/@uppy/companion/src/standalone/index.js b/packages/@uppy/companion/src/standalone/index.js index 0409c6acd..f59b27526 100644 --- a/packages/@uppy/companion/src/standalone/index.js +++ b/packages/@uppy/companion/src/standalone/index.js @@ -31,13 +31,20 @@ if (app.get('env') !== 'test') { // log server requests. app.use(morgan('combined')) morgan.token('url', (req, res) => { - // don't log access_tokens in urls - if (req.query && req.query.access_token) { + const mask = (key) => { + // don't log access_tokens in urls const query = Object.assign({}, req.query) // replace logged access token with xxxx character - query.access_token = 'x'.repeat(req.query.access_token.length) + query[key] = 'x'.repeat(req.query[key].length) return `${req.path}?${qs.stringify(query)}` } + + if (req.query && req.query['access_token']) { + return mask('access_token') + } else if (req.query && req.query['uppyAuthToken']) { + return mask('uppyAuthToken') + } + return req.originalUrl || req.url })