From 2f092da1067dfaadca47ef7bace4b9b15bc8614b Mon Sep 17 00:00:00 2001 From: Matteo Padovano Date: Fri, 2 Aug 2019 13:10:37 +0200 Subject: [PATCH] fix wrong definition for metaFields property (#1763) * fix wrong definition for metaFields property * dashboard: add type test for metaFields --- packages/@uppy/dashboard/types/dashboard-tests.ts | 8 ++++++-- packages/@uppy/dashboard/types/index.d.ts | 8 +++++++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/packages/@uppy/dashboard/types/dashboard-tests.ts b/packages/@uppy/dashboard/types/dashboard-tests.ts index 956859c60..762e882e8 100644 --- a/packages/@uppy/dashboard/types/dashboard-tests.ts +++ b/packages/@uppy/dashboard/types/dashboard-tests.ts @@ -15,9 +15,13 @@ import Dashboard = require('../') { const uppy = Uppy() - uppy.use(Dashboard, { + uppy.use(Dashboard, >{ width: '100%', - height: 700 + height: 700, + metaFields: [ + { id: 'caption', name: 'Caption' }, + { id: 'license', name: 'License', placeholder: 'Creative Commons, Apache 2.0, ...' }, + ] }) } diff --git a/packages/@uppy/dashboard/types/index.d.ts b/packages/@uppy/dashboard/types/index.d.ts index 301773ff1..4dfbdc9ef 100644 --- a/packages/@uppy/dashboard/types/index.d.ts +++ b/packages/@uppy/dashboard/types/index.d.ts @@ -1,5 +1,11 @@ import Uppy = require('@uppy/core'); +interface MetaField { + id: string; + name: string; + placeholder?: string; +} + declare module Dashboard { interface DashboardOptions extends Uppy.PluginOptions { onRequestCloseModal: () => void; @@ -14,7 +20,7 @@ declare module Dashboard { note: string; showLinkToFileUploadResult: boolean; proudlyDisplayPoweredByUppy: boolean; - metaFields: string[]; + metaFields: MetaField[]; plugins: string[]; disableStatusBar: boolean; showProgressDetails: boolean;