From 272b199dc9eb9091dab3a9cd319584fda5549e72 Mon Sep 17 00:00:00 2001 From: Prakash Date: Fri, 22 May 2026 21:59:05 +0530 Subject: [PATCH] apply feedback --- .../src/server/controllers/bridge-tokens.ts | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/@uppy/companion/src/server/controllers/bridge-tokens.ts b/packages/@uppy/companion/src/server/controllers/bridge-tokens.ts index 3762d088f..7600e81c1 100644 --- a/packages/@uppy/companion/src/server/controllers/bridge-tokens.ts +++ b/packages/@uppy/companion/src/server/controllers/bridge-tokens.ts @@ -1,4 +1,5 @@ import type { Request, Response } from 'express' +import logger from '../logger.js' /** * Returns the decrypted Dropbox OAuth tokens for the current session. @@ -12,9 +13,12 @@ export default function bridgeTokens(req: Request, res: Response): void { // provider cannot be read here: `verifyToken` decrypts against this same param, // so a mismatched path is rejected by the middleware before reaching this point. if (req.params['providerName'] !== 'dropbox') { - res - .status(400) - .json({ error: 'The bridge-tokens endpoint only supports Dropbox.' }) + logger.warn( + `bridge-tokens called for unsupported provider: ${req.params['providerName']}`, + 'bridge-tokens', + req.id, + ) + res.status(400).end() return } @@ -22,7 +26,12 @@ export default function bridgeTokens(req: Request, res: Response): void { if (session?.accessToken == null) { // The auth token decrypted fine, but this session has no connected Dropbox // account — that is "not found", not an authentication failure. - res.status(404).json({ error: 'No Dropbox tokens for this session.' }) + logger.info( + 'bridge-tokens: no Dropbox tokens for this session', + 'bridge-tokens', + req.id, + ) + res.status(404).end() return }