Mirrors/uppy
1
0
Fork 0
mirror of https://github.com/transloadit/uppy.git synced 2026-07-28 04:34:01 +00:00
Code Issues Projects Releases Wiki Activity

remove chunkSize backwards compatibility (#3830)

Browse source 
see #3511
This commit is contained in:
Mikael Finstad 2022-06-26 22:05:56 -07:00 • committed by GitHub
parent abf9394aea
commit 0dc59e854b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
packages/@uppy/companion/src/server/Uploader.js
View file

@ -635,14 +635,6 @@ class Uploader {
const filename = this.uploadFileName
const { client, options } = this.options.s3
function getPartSize (chunkSize) {
// backwards compatibility https://github.com/transloadit/uppy/pull/3511#issuecomment-1050797935
// requires min 5MiB and max 5GiB partSize
// todo remove this logic in the next major semver
if (chunkSize == null || chunkSize >= 5368709120 || chunkSize <= 5242880) return undefined
return chunkSize
}
const params = {
Bucket: options.bucket,
Key: options.getKey(null, filename, this.options.metadata),
@ -655,7 +647,8 @@ class Uploader {
if (options.acl != null) params.ACL = options.acl
const upload = client.upload(params, {
partSize: getPartSize(this.options.chunkSize),
// using chunkSize as partSize too, see https://github.com/transloadit/uppy/pull/3511
partSize: this.options.chunkSize,
})
upload.on('httpUploadProgress', ({ loaded, total }) => {