Merge pull request #5 from janoodleFTW/fix/1-build.gradle-issues

Fix build issues on Android related to versioning

android/README.md

@@ -22,4 +22,8 @@ storeFile=../key.jks
 
 Where you set the `storePassword` and the `keyPassword`. You can also change the alias.
 
+You will need to uncomment the section `signingConfigs` in the `app/build.gradle`.
+
+And change the `signingConfig signingConfigs.debug` to `signingConfig signingConfigs.release`.
+
 You can also provide this files from your CI instead of including this in the project.

android/app/build.gradle

@@ -47,20 +47,20 @@ android {
         minSdkVersion 21 // avoid max 64k method limit
         targetSdkVersion 28
 
-        def (majorNum, minorNum, buildNum) = flutterVersionName.tokenize( '.' )
-        versionCode majorNum.toInteger() * 1_000_000 + minorNum.toInteger() * 1_000 + buildNum.toInteger()
+        versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
 
-    signingConfigs {
-        release {
-            keyAlias keystoreProperties['keyAlias']
-            keyPassword keystoreProperties['keyPassword']
-            storeFile file(keystoreProperties['storeFile'])
-            storePassword keystoreProperties['storePassword']
-        }
-    }
+//     signingConfigs {
+//         release {
+//             keyAlias keystoreProperties['keyAlias']
+//             keyPassword keystoreProperties['keyPassword']
+//             storeFile file(keystoreProperties['storeFile'])
+//             storePassword keystoreProperties['storePassword']
+//         }
+//     }
+
     buildTypes {
         debug {
             // app id will be "de.janoodle.circlesApp.debug"
@@ -69,7 +69,7 @@ android {
         release {
             // NOTE: ProGuard is not enabled at the moment
             // See: https://flutter.dev/docs/deployment/android to enable it
-            signingConfig signingConfigs.release
+            signingConfig signingConfigs.debug
         }
     }
 

pubspec.yaml

@@ -9,7 +9,7 @@ description: Timy group messaging app
 # In Android, build-name is used as versionName while build-number used as versionCode.
 # Read more about Android versioning at https://developer.android.com/studio/publish/versioning
 
-version: 1.0.23+1
+version: 1.0.0+1
 
 environment:
   sdk: ">=2.2.2 <3.0.0"