mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-01-23 02:36:05 +00:00
ea5fbb60af
**Problem:** E2E tests started failing after PR #6010 with timeouts when clicking the Tags group button in the sidebar. The failure occurred in tag deletion and removal tests that previously worked. **Root Cause:** PR #6010 added `<div (click)="$event.stopPropagation()">` wrapper around tag menu items to prevent menu closure when toggling tags. However, this prevented Material CDK from detecting clicks properly, leaving overlay backdrops in the DOM after menu operations. These lingering backdrops blocked subsequent clicks on the Tags sidebar button, causing Playwright to timeout waiting for the element to become "stable". **Solution:** Added explicit waits for `.cdk-overlay-backdrop` to disappear after menu operations in: - `assignTagToTask()`: Wait after assigning tag via context menu - `removeTagFromTask()`: Wait after removing tag via context menu - `deleteTag()`: Wait before attempting to interact with sidebar **Changes:** - e2e/pages/tag.page.ts: Add overlay cleanup waits with proper error handling - All waits use `.catch(() => {})` to gracefully handle cases where no overlay exists **Testing:** Verified with `npm run checkFile e2e/pages/tag.page.ts` - all checks pass. Fixes failing tests: - tags/tag-crud.spec.ts:47 "should remove tag from task via context menu" - tags/tag-crud.spec.ts:80 "should delete tag and update tasks" - tags/tag-crud.spec.ts:117 "should navigate to tag view when clicking tag in sidebar" - menu/menu-touch-submenu.spec.ts:71 "should support toggling tags via submenu" - sync/webdav-sync-delete-cascade.spec.ts:77 "Delete tag with archived tasks syncs" |
||
|---|---|---|
| .. | ||
| base.page.ts | ||
| dialog.page.ts | ||
| import.page.ts | ||
| index.ts | ||
| note.page.ts | ||
| planner.page.ts | ||
| project.page.ts | ||
| schedule.page.ts | ||
| settings.page.ts | ||
| side-nav.page.ts | ||
| supersync.page.ts | ||
| sync.page.ts | ||
| tag.page.ts | ||
| task.page.ts | ||
| work-view.page.ts | ||