mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-18 00:46:45 +00:00
10a3db97ea
* docs: add plan for Android background sync via WorkManager Outlines the implementation plan for using WorkManager to periodically sync with SuperSync server in the background, cancelling stale reminders for tasks that were completed/deleted on other devices. https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * docs: refine plan based on multi-agent architecture review - Pin frontend hook to SyncProviderManager.currentProviderPrivateCfg$ - Add skipWhileApplyingRemoteOps() guard for selector-based effect - Add HRX (dismiss reminder) and deadlineRemindAt to parser - Add batch operation ds field handling - Add ProGuard rules step for release builds - Add error handling note for BootReceiver WorkManager enqueue https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * docs: improve plan after second review round Key changes: - Remove Step 5 (ReminderAlarmStore lookup) - hash-based cancellation is sufficient, no store lookup needed - Add BackgroundSyncProvider interface for extensibility to Dropbox/WebDAV - Per-account lastServerSeq keyed by baseUrl hash - Add SyncReminderScheduler helper to deduplicate scheduling logic - Document edge cases: account switching, token expiry, force-kill, gapDetected, notification race conditions - Add extensibility section explaining Dropbox feasibility and architecture https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * feat(android): add background sync to cancel stale reminders via WorkManager When a task is completed/deleted on desktop, Android reminders for that task would still fire because the mobile app didn't know about the change. This adds a WorkManager periodic job (every 15 min) that fetches operations from the SuperSync server and cancels AlarmManager alarms + notifications for tasks that are done, deleted, archived, or had their reminders dismissed. Architecture: - BackgroundSyncProvider interface for extensibility (Dropbox/WebDAV possible later) - SuperSyncBackgroundProvider: lightweight HTTP client + operation parser - SyncReminderWorker: CoroutineWorker that fetches ops and cancels reminders - SyncReminderScheduler: helper to schedule/cancel the WorkManager job - AndroidSyncBridgeEffects: mirrors SuperSync credentials to native SharedPreferences - Per-account lastServerSeq prevents account-switching bugs https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * chore: update package-lock.json after npm install https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * fix(android): address review issues and add tests for background sync Fixes from code review: - Fix distinctUntilChanged to properly handle provider switching (non-SuperSync emissions now treated as equal to prevent repeated clears) - Add null-safe ops array parsing in SuperSyncBackgroundProvider - Add write/call timeouts to OkHttpClient (30s write, 60s call) - Remove no-op `hash and hash` line in Kotlin hash function Tests: - Add cross-platform parity tests for notification ID hash function (pinned expected values that must match Kotlin implementation) - Add AndroidSyncBridgeEffects unit tests covering: - distinctUntilChanged comparator behavior - credential set/clear decision logic - observable filtering integration (dedup, null filtering) https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * fix(android): fix hash overflow and operation parser payload paths Two critical bugs found during final review: 1. Hash function abs(Int.MIN_VALUE) bug: In Kotlin, abs(Int.MIN_VALUE) returns Int.MIN_VALUE (still negative) due to 32-bit overflow. Fixed by converting to Long before abs(), matching JS behavior where Math.abs works on 64-bit floats. 2. Operation parser payload structure: The parser was looking at p.isDone and p.task.changes directly, but the actual compact operation format wraps everything in p.entityChanges[] and p.actionPayload. Rewrote to use p.entityChanges as primary source (consistent structure with entityType, entityId, changes fields) and p.actionPayload.task.changes as secondary source. https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * docs: add long-term plan for Android background sync improvements Covers three phases: fast app startup via cached sync seq, push-based notification cancellation via FCM, and extending background sync to Dropbox/WebDAV providers. https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe * fix(android): address review feedback for background reminder sync - Remove PLAN.md from repo root (C1) - Use EncryptedSharedPreferences for access token storage with fallback to standard SharedPreferences on broken KeyStore (C2) - Reset lastServerSeq when access token changes to prevent stale seq on account switch with same server URL (I1) - Add max iteration guard (100) to pagination loop to prevent infinite loops from server bugs (I2) - Use type predicate filter instead of non-null assertions (I3) - Add exponential backoff (5min) to WorkManager schedule (S1) - Add comments linking action type codes to frontend source (S2) - Extract distinctUntilChanged comparator to named function with JSDoc explaining the suppression semantics (S3) https://claude.ai/code/session_01RkrVBB492k8RBA8zt5swwe --------- Co-authored-by: Claude <noreply@anthropic.com>
24 lines
892 B
Prolog
24 lines
892 B
Prolog
# Add project specific ProGuard rules here.
|
|
# You can control the set of applied configuration files using the
|
|
# proguardFiles setting in build.gradle.
|
|
#
|
|
# For more details, see
|
|
# http://developer.android.com/guide/developing/tools/proguard.html
|
|
|
|
# If your project uses WebView with JS, uncomment the following
|
|
# and specify the fully qualified class name to the JavaScript interface
|
|
# class:
|
|
#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
|
|
# public *;
|
|
#}
|
|
|
|
# Uncomment this to preserve the line number information for
|
|
# debugging stack traces.
|
|
#-keepattributes SourceFile,LineNumberTable
|
|
|
|
# If you keep the line number information, uncomment this to
|
|
# hide the original source file name.
|
|
#-renamesourcefileattribute SourceFile
|
|
|
|
# Keep WorkManager worker classes (used for background sync reminder cancellation)
|
|
-keepnames class * extends androidx.work.CoroutineWorker
|