super-productivity/electron
Johannes Millan 6faca760f0
fix: address review findings from daily changes (#6944)
* fix: address review findings from daily changes

- Add setPermissionCheckHandler alongside setPermissionRequestHandler
  for defense-in-depth in Electron (permission queries now also denied)
- Fix tagIds merge ordering in issue service: provider adapter tags are
  now merged with default tags instead of being silently overwritten
- Execute deleteTask action last in automations to prevent subsequent
  actions from failing on a deleted task
- Add unit tests for getTaskDefaults logic (TODAY_TAG filtering,
  defaultNote, tagIds merging, deduplication, context tags)
- Add test for deleteTask execution ordering in ActionExecutor

https://claude.ai/code/session_01UhoR5g7RQgm4E6bZCvU9PS

* refactor: revert YAGNI changes from review fixes

- Revert tagIds merge in issue.service.ts: no provider currently sets
  tagIds in getAddTaskData, so merging solves a hypothetical problem
- Revert deleteTask sort in action-executor: the automations feature is
  new and nobody has hit this edge case yet
- Remove tests for reverted behavior, keep tests for existing features
  (TODAY_TAG filtering, defaultNote, note override prevention)

https://claude.ai/code/session_01UhoR5g7RQgm4E6bZCvU9PS

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-03-24 12:11:47 +01:00
..
assets/icons fix: wrong icon for kde title bar 2025-07-22 20:42:28 +02:00
ipc-handlers refactor: add markdown renderer tests and remove dead IPC code 2026-01-26 20:55:29 +01:00
overlay-indicator feat(overlay): resizable responsive overlay with opacity and always-show 2026-03-20 21:36:30 +01:00
scripts refactor(electron): bundle preload script with esbuild to support sandbox mode 2026-03-22 19:38:21 +01:00
shared-with-frontend feat(two-way-sync): add plugin OAuth, two-way field sync, and remote issue deletion 2026-03-22 13:02:41 +01:00
backup.ts chore(backup): increase retention to 30 recent and 21 daily 2026-02-11 20:37:40 +01:00
clipboard-image-handler.ts Adding Ctrl-V pasting function from clipboard. (#5998) 2026-02-04 15:46:51 +01:00
common.const.ts fix: windows crashing issue on minimize #3423 2024-09-09 15:17:24 +02:00
CONFIG.ts Increase ping interval and idle time in order to not waste CPU cycles. (#6227) 2026-01-28 15:37:50 +01:00
debug.ts refactor: improve typing 2025-08-13 19:47:44 +02:00
electronAPI.d.ts feat(two-way-sync): add plugin OAuth, two-way field sync, and remote issue deletion 2026-03-22 13:02:41 +01:00
error-handler-with-frontend-inform.ts fix(error-handling): prevent [object Object] from appearing in error messages 2026-01-02 15:40:14 +01:00
full-screen-blocker.ts feat: improve shutdown cleanup 2025-06-29 17:31:28 +02:00
idle-time-handler.ts fix(electron): reduce idle detection log verbosity 2025-12-31 13:42:18 +01:00
indicator.ts feat(overlay): resizable responsive overlay with opacity and always-show 2026-03-20 21:36:30 +01:00
ipc-handler-wrapper.ts Adding Ctrl-V pasting function from clipboard. (#5998) 2026-02-04 15:46:51 +01:00
ipc-handler.ts Adding Ctrl-V pasting function from clipboard. (#5998) 2026-02-04 15:46:51 +01:00
jira.ts fix: add proxy env support for jira integration #6324 (#6574) 2026-03-09 13:09:51 +01:00
local-file-sync.ts refactor(sync): clean up file-based sync adapter dead code and duplication 2026-02-15 11:19:22 +01:00
lockscreen.ts refactor(elctron): add typing wherever possible and simplify 2022-01-30 20:12:41 +01:00
main-window.ts fix: address review findings from daily changes (#6944) 2026-03-24 12:11:47 +01:00
main.ts fix(electron): improve protocol URL handling and register URL scheme on Linux 2026-03-05 16:45:05 +01:00
plugin-node-executor.ts refactor: improve typing 2 2025-08-12 15:27:48 +02:00
plugin-oauth.ts feat(two-way-sync): add plugin OAuth, two-way field sync, and remote issue deletion 2026-03-22 13:02:41 +01:00
preload.ts feat(two-way-sync): add plugin OAuth, two-way field sync, and remote issue deletion 2026-03-22 13:02:41 +01:00
protocol-handler.ts fix(electron): restore hidden window on taskbar click 2026-01-20 17:07:23 +01:00
proxy-agent.ts fix: add proxy env support for jira integration #6324 (#6574) 2026-03-09 13:09:51 +01:00
shared-state.ts fix: refactor tray handling to use shared state for task and countdown visibility 2025-11-28 18:53:00 +01:00
simple-store.ts fix(electron): handle legacy simpleSettings directory causing EISDIR crash 2026-02-25 15:27:57 +01:00
start-app.ts fix(electron): enable webSecurity, add permission handler, improve cert logging 2026-03-23 10:52:43 +01:00
tsconfig.electron.json fix(e2e): improve supersync test stability and build compatibility 2025-12-19 09:59:44 +01:00
various-shared.ts feat(overlay): resizable responsive overlay with opacity and always-show 2026-03-20 21:36:30 +01:00