Johannes Millan 4e0e2d9ffd fix(electron): open file:// URLs with special characters on Windows (#8695) (#8698) ... * fix(electron): open file:// URLs with special characters (#8695) Local file:// URLs with non-ASCII names or spaces (e.g. Grüne, "Another One") failed to open on Windows: both open sinks handed the URL to shell.openExternal, which percent-encodes the path (ü → %C3%BC, space → %20) before ShellExecute, so the OS then searched for a literally-named folder and failed. Pure-ASCII paths worked because there was nothing to encode. Route local file: URLs through shell.openPath with a decoded filesystem path (fileURLToPath) instead. openPath takes a raw path, so Unicode names and spaces open correctly. This also applies the executable-extension guard to file: URLs, which previously only ran on the OPEN_PATH sink (GHSA-hr87-735w-hfq3). Shared openLocalPath()/isLocalFileUrl() cover both the OPEN_EXTERNAL IPC handler and the navigation-interception path in main-window. * test(electron): cover NTLM/exec vectors at the un-pre-gated openPath sink Follow-up to the #8695 review. Add regression tests locking in that openLocalPath alone (OPEN_PATH has no scheme pre-gate) blocks the path-based UNC file: URL (file:////host/share, GHSA-hr87-735w-hfq3) and an executable hidden behind a percent-encoded dot (evil%2Ebat). Document that the decode tests run on Linux and therefore don't exercise the Windows drive-letter/backslash conversion, and clarify why isLocalFileUrl is intentionally broader than the renderer/scheme-allowlist checks.		2026-07-02 11:47:51 +02:00
..
assets/icons	fix(electron): crisp, flicker-free Linux tray icon (#4905) (#8484)	2026-06-19 12:43:00 +02:00
ipc-handlers	fix(electron): open file:// URLs with special characters on Windows (#8695) (#8698)	2026-07-02 11:47:51 +02:00
scripts	refactor(electron): bundle preload script with esbuild to support sandbox mode	2026-03-22 19:38:21 +01:00
shared-with-frontend	fix(electron): block executable launch via shell.openPath (#8668)	2026-07-01 17:56:24 +02:00
task-widget	Feat/task widget global shortcut (#7099)	2026-06-09 16:11:16 +02:00
wayland-idle-helper	Add ext-idle-notify backend for Wayland idle detection (#7337)	2026-04-24 16:50:24 +02:00
app-control.test.cjs	fix(electron): respect tray title settings #7823 (#8097)	2026-06-08 12:07:09 +02:00
backup.ts	fix(electron): restrict loadBackupData IPC to the backup directory (#8206)	2026-06-09 15:29:06 +02:00
bundled-plugin-ids.test.cjs	feat(plugins): allow uploaded nodeExecution behind consent gate (#8576)	2026-06-25 16:45:54 +02:00
clear-stale-idb-locks.ts	Feat/to me it looks like there are lots of 60dd04 (#7280)	2026-04-20 12:04:38 +02:00
clipboard-image-handler.test.cjs	fix(security): restrict renderer-supplied filesystem IPC paths (#8223)	2026-06-09 18:16:22 +02:00
clipboard-image-handler.ts	fix(security): restrict renderer-supplied filesystem IPC paths (#8223)	2026-06-09 18:16:22 +02:00
common-const.test.cjs	refactor(sync): remove unused error classes, dialog, and constructor-time logging (phase 1, #8325) (#8510)	2026-06-20 13:36:56 +02:00
common.const.ts	fix(electron): restore custom title bar on GNOME-X11 (#8483) (#8485)	2026-06-19 12:42:44 +02:00
CONFIG.ts	Increase ping interval and idle time in order to not waste CPU cycles. (#6227)	2026-01-28 15:37:50 +01:00
debug.ts	refactor: rename overlay-indicator to task-widget	2026-03-30 22:00:47 +02:00
electronAPI.d.ts	fix(electron): remove exec IPC to close GHSA-256q (#8669)	2026-07-01 17:55:35 +02:00
error-handler-with-frontend-inform.ts	fix(error-handling): prevent [object Object] from appearing in error messages	2026-01-02 15:40:14 +01:00
exec.test.cjs	fix(electron): remove exec IPC to close GHSA-256q (#8669)	2026-07-01 17:55:35 +02:00
file-path-guard.test.cjs	fix(security): restrict renderer-supplied filesystem IPC paths (#8223)	2026-06-09 18:16:22 +02:00
file-path-guard.ts	fix(security): restrict renderer-supplied filesystem IPC paths (#8223)	2026-06-09 18:16:22 +02:00
full-screen-blocker.ts	fix(security): harden XSS sinks and add Origin check (#7413)	2026-05-06 21:37:06 +02:00
gpu-startup-guard.ts	fix(electron): add GPU startup guard for confined Linux packages	2026-04-20 18:35:31 +02:00
idle-time-handler.ts	fix(electron): retry Wayland idle helper startup (#7527)	2026-05-10 22:35:33 +02:00
image-cache.test.cjs	feat(electron): restore bmp/avif background image support	2026-06-10 17:04:26 +02:00
image-cache.ts	feat(electron): restore bmp/avif background image support	2026-06-10 17:04:26 +02:00
indicator.test.cjs	refactor(sync): remove unused error classes, dialog, and constructor-time logging (phase 1, #8325) (#8510)	2026-06-20 13:36:56 +02:00
indicator.ts	fix(electron): crisp, flicker-free Linux tray icon (#4905) (#8484)	2026-06-19 12:43:00 +02:00
ipc-handler-wrapper.test.cjs	fix(security): restrict renderer-supplied filesystem IPC paths (#8223)	2026-06-09 18:16:22 +02:00
ipc-handler-wrapper.ts	fix(security): restrict renderer-supplied filesystem IPC paths (#8223)	2026-06-09 18:16:22 +02:00
ipc-handler.ts	fix(electron): remove exec IPC to close GHSA-256q (#8669)	2026-07-01 17:55:35 +02:00
jira.ts	fix(jira): honor no_proxy for electron requests #6324 (#8177)	2026-06-09 15:00:43 +02:00
local-file-sync.test.cjs	Merge master and address PR review findings	2026-06-10 19:17:54 +02:00
local-file-sync.ts	fix(electron): guard sync-folder cache against stale-load clobber	2026-06-10 20:35:00 +02:00
local-rest-api.ts	fix(security): harden XSS sinks and add Origin check (#7413)	2026-05-06 21:37:06 +02:00
lockscreen.ts	fix(electron): restore macOS lock screen by correcting osascript quoting	2026-04-16 19:47:52 +02:00
main-window.ts	fix(electron): open file:// URLs with special characters on Windows (#8695) (#8698)	2026-07-02 11:47:51 +02:00
main.ts	fix(electron): improve protocol URL handling and register URL scheme on Linux	2026-03-05 16:45:05 +01:00
navigation-guard.test.cjs	fix(electron): lock in-window navigation to the app's loaded origin (#8230)	2026-06-09 22:34:15 +02:00
navigation-guard.ts	fix(electron): lock in-window navigation to the app's loaded origin (#8230)	2026-06-09 22:34:15 +02:00
open-url.test.cjs	fix(electron): open file:// URLs with special characters on Windows (#8695) (#8698)	2026-07-02 11:47:51 +02:00
open-url.ts	fix(electron): open file:// URLs with special characters on Windows (#8695) (#8698)	2026-07-02 11:47:51 +02:00
plugin-node-consent-store.test.cjs	feat(plugins): persist nodeExecution consent per plugin (#8512) (#8600)	2026-06-29 16:12:00 +02:00
plugin-node-consent-store.ts	feat(plugins): persist nodeExecution consent per plugin (#8512) (#8600)	2026-06-29 16:12:00 +02:00
plugin-node-executor.test.cjs	feat(plugins): persist nodeExecution consent per plugin (#8512) (#8600)	2026-06-29 16:12:00 +02:00
plugin-node-executor.ts	feat(plugins): persist nodeExecution consent per plugin (#8512) (#8600)	2026-06-29 16:12:00 +02:00
plugin-oauth.ts	feat(plugins): generic OAuth hooks for issue-provider plugins (#8546)	2026-06-30 14:11:00 +02:00
preload.ts	fix(electron): remove exec IPC to close GHSA-256q (#8669)	2026-07-01 17:55:35 +02:00
protocol-handler.test.cjs	feat(electron): trigger global shortcuts via superproductivity:// URLs (#8645)	2026-06-30 17:22:30 +02:00
protocol-handler.ts	feat(plainspace): Collaborate-on-Plainspace discovery + smoother connect (#8649)	2026-07-01 16:39:34 +02:00
proxy-agent.test.cjs	fix(jira): honor no_proxy for electron requests #6324 (#8177)	2026-06-09 15:00:43 +02:00
proxy-agent.ts	fix(jira): honor no_proxy for electron requests #6324 (#8177)	2026-06-09 15:00:43 +02:00
shared-state.ts	fix: refactor tray handling to use shared state for task and countdown visibility	2025-11-28 18:53:00 +01:00
simple-store.test.cjs	fix(electron): harden simple store writes (#7297)	2026-04-21 15:03:30 +02:00
simple-store.ts	fix(electron): harden simple store writes (#7297)	2026-04-21 15:03:30 +02:00
start-app.ts	fix(electron): use display name for Linux notifications (#8640)	2026-06-30 14:01:01 +02:00
sync-path-resolver.test.cjs	feat(electron): add sync-path-resolver for renderer-supplied paths	2026-06-09 22:23:47 +02:00
sync-path-resolver.ts	feat(electron): add sync-path-resolver for renderer-supplied paths	2026-06-09 22:23:47 +02:00
task-widget.test.cjs	Feat/task widget global shortcut (#7099)	2026-06-09 16:11:16 +02:00
tsconfig.electron.json	fix(keyboard): resolve macOS global shortcut layout mismatch (#8378) (#8381)	2026-06-17 12:57:47 +02:00
various-shared.test.cjs	feat(electron): trigger global shortcuts via superproductivity:// URLs (#8645)	2026-06-30 17:22:30 +02:00
various-shared.ts	feat(electron): trigger global shortcuts via superproductivity:// URLs (#8645)	2026-06-30 17:22:30 +02:00