mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-18 00:46:45 +00:00
#8709 added a mandatory disableClose "Encrypt before first upload?" modal on every fresh file-based sync setup. The setupWebdavSync helper dismissed it with locator.isVisible({ timeout }), but isVisible() returns the CURRENT state immediately and never polls — the timeout is effectively ignored. The modal opens only after save()'s awaited provider-auth check and a lazy import() of the dialog chunk, so it appears a beat after the Save click; isVisible() raced it, returned false, and the Skip click was never issued. The leftover backdrop then blocked every following interaction, failing ~11-12 @webdav specs per run with "cdk-overlay-backdrop intercepts pointer events" and conflict dialogs that never appeared. It passed only when the modal happened to already be up at the instant of the check, which is why the failures looked flaky. Use waitFor({ state: 'visible' }), which actually polls until the modal appears, then click Skip and confirm it closes. Apply the same wait to the encrypt-at- setup fill path. Verified green via a full @webdav CI run. |
||
|---|---|---|
| .. | ||
| base.page.ts | ||
| dialog.page.ts | ||
| import.page.ts | ||
| index.ts | ||
| note.page.ts | ||
| planner.page.ts | ||
| project.page.ts | ||
| schedule.page.ts | ||
| settings.page.ts | ||
| side-nav.page.ts | ||
| supersync.page.ts | ||
| sync.page.ts | ||
| tag.page.ts | ||
| task.page.ts | ||
| work-view.page.ts | ||