mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-29 18:50:07 +00:00
7291f2fdc8
* docs(sync): clarify multi-device token usage * fix(backup): show Windows Store backup path only if it exists Settings showed the MSIX-virtualized path unconditionally under process.windowsStore, without ever checking it is there. On installs where the package is not virtualized the backups sit in the real AppData\Roaming, so the settings page advertised a folder that does not exist and rendered a dead file:// link - for the backup feature, whose whole point is being findable after a disaster (#9209). AppData redirection is not a constant: it applies only to virtualized packages, and since Windows 10 1903 the OS resolves it per file. That is why #995 and #9209 report the exact opposite symptom and both are right. Probe for the directory instead of assuming, and fall back to the path we actually write to, which is correct in either case. Closes #9209 * fix(backup): pin the Windows Store backup path with a regression test Follow-up to the previous commit, addressing multi-agent review. Move the display-path decision next to the constants it reads, as getBackupDirForDisplay(). BACKUP_DIR_WINSTORE stops being exported, so the rule "verify before displaying" is enforced by the only accessor instead of being an honour-system note in a doc comment - which is the shape the 2025 fix got wrong. backup.ts already imports existsSync, so this costs no new import and matches getRelaunchExecPath in ipc-handlers/app-control.ts. Correct the doc comment: it claimed BACKUP_DIR_WINSTORE is never read, while BACKUP_LOAD_DATA accepts it as an allow-listed read root fifty lines below. Left as-is otherwise; narrowing a GHSA-x937-wf3j-88q3 guard does not belong in a display-path fix. Add electron/backup.test.cjs pinning both directions of the loop this bug has already run once: Store + LocalCache present must show it (#995), Store + LocalCache absent must fall back (#9209). Verified by sabotage - restoring the unconditional path fails the #9209 case, deleting the probe fails the #995 case, and each kills only its own test. Document the two accepted shortcuts with their ceiling and upgrade path: the hardcoded package family name (unverifiable from source, degrades gracefully), and the stale LocalCache dir left by a virtualized to full-trust flip. * docs(backup): record how the hardcoded package family name was verified Computed it from the shipped v18.15.1 AppxManifest: PublisherId is the first 8 bytes of SHA-256 over the UTF-16LE Publisher string in base32 (digits + a-z minus i/l/o/u). CN=AC30A249-AFE7-4B23-AE54-A95B4FDF8928 yields ch45amy23cdv6, matching the constant exactly - so it has not drifted, and the previous comment's claim that it cannot be verified was too pessimistic: any release artifact re-checks it without Windows. * docs: trim backup path comments and document the electron test harness Cut the duplicated MSIX explanation across the two doc blocks (-7 lines) while keeping the parts that stop this bug round-tripping a third time: the per-file 1903 semantics, the #995/#9209 link, and both shortcuts' ceilings. Add npm run test:electron to AGENTS.md. It was absent, and the harness is easy to miss because it uses electron/*.test.cjs while the rest of the repo uses .spec.ts - which tsconfig.electron.json actively excludes, so a spec dropped there silently never runs. Searching for the repo's dominant convention turns up nothing and invites the conclusion that main-process code is untestable; it is not. |
||
|---|---|---|
| .. | ||
| long-term-plans | ||
| plans | ||
| promotion | ||
| research | ||
| screens | ||
| sync-and-op-log | ||
| wiki | ||
| add-new-integration.md | ||
| android-edge-to-edge-keyboard.md | ||
| apple-release-automation.md | ||
| build-and-publish-notes.md | ||
| documentation-guide.md | ||
| ENV_SETUP.md | ||
| github-access-token-instructions.md | ||
| gitlab-access-token-instructions.md | ||
| handover.md | ||
| how-to-rate.md | ||
| howto-refresh-snap-credentials.md | ||
| i18n-script-usage.md | ||
| legacy-webview-analysis.md | ||
| mac-app-store-code-signing-guide.md | ||
| non-sync-code-simplification-audit.md | ||
| performance-project-tag-report.md | ||
| plainspace-api-extension-plan.md | ||
| plainspace-integration-plan.md | ||
| plugin-development.md | ||
| styling-guide.md | ||
| theming-contract.md | ||
| TRANSLATING.md | ||
| unused-translations-analysis.md | ||
| update-android-app.md | ||
| update-mac-certificates.md | ||