mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-28 02:04:30 +00:00
5324512ae5
Three bugs fixed: 1. dialog-view-task-reminders: cancel onRemindersActive$ subscription immediately in _close() rather than waiting for ngOnDestroy (~300ms later after animation). A worker tick arriving during the close animation could call taskIds$.next() on an OnPush component being torn down by CDK, corrupting Angular change detection. Guard _close() with MatDialogState to prevent double-close. 2. reminder.module.ts: fix merge([obs1, obs2]) → merge(obs1, obs2). RxJS 7 treats the array as a single ObservableInput, emitting Observable objects as values instead of subscribing to them, so the add-task-bar wait never actually waited. 3. reminder.module.ts: remove dead .afterClosed() chain that was never subscribed to (no-op since the very first TASK reminder implementation). Adds tests for the close-animation race condition covering the exact sequence from issue #7189: Task A play → Task B reminder during animation window. Fixes #7189 |
||
|---|---|---|
| .. | ||
| app | ||
| assets | ||
| environments | ||
| static | ||
| styles | ||
| test-helpers | ||
| typings | ||
| _common.scss | ||
| favicon.ico | ||
| hammer-config.class.ts | ||
| index.html | ||
| karma.conf.js | ||
| main.ts | ||
| manifest.json | ||
| polyfills.ts | ||
| styles.scss | ||
| test.ts | ||
| tsconfig.app.json | ||
| tsconfig.spec.json | ||
| tsconfig.worker.json | ||