mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-17 16:37:43 +00:00
* fix(issue): prevent crash from orphan issueProviderId (#7135) The Jira image-headers effect in task-detail-panel subscribed to selectIssueProviderById without an error handler, so a task with an issueProviderId pointing at a deleted provider (e.g. after sync convergence where taskIdsToUnlink didn't cover all local tasks) propagated the selector throw to Zone.js as a crash dialog. Wrap the inner selector observable in catchError that logs and falls back to of(null); the downstream jiraCfg?.isEnabled guard handles the fallback. Also drop IssueLog.log(issueProviderKey, issueProvider) from the throwing variant of the selector: providers may carry credentials (host, token, apiKey) and IssueLog history is exportable. * fix(focus-mode): sync tray countdown with in-app timer during breaks Tray title was rebuilt from a cached currentFocusSessionTime that only refreshed when CURRENT_TASK_UPDATED fired. addTimeSpent is gated on an active current task, so during focus-mode breaks or task-less focus sessions the cache froze while the in-app timer kept ticking. Add the tick action to taskChangeElectron$ so the cache refreshes every second whenever the focus timer is running. Fixes #7278 * fix(ci): restore GitHub Actions SHA pins undone by0e9218bd68Commit0e9218bd68silently reverted PR #7212 (github-actions-minor group bump) along with its stated sync/client-id work. This restores the 15 workflow files to their pre-revert state. Actions restored to newer pinned SHAs: - actions/upload-artifact v7.0.0 -> v7.0.1 - step-security/harden-runner v2.16.1 -> v2.17.0 - softprops/action-gh-release v2.6.1 -> v3.0.0 - signpath/github-action-submit-signing-request v2.0 -> v2.1 - anthropics/claude-code-action v1.0.89 -> v1.0.93 - docker/build-push-action v7.0.0 -> v7.1.0 - easingthemes/ssh-deploy v5.1.1 -> v6.0.3 * fix: restore i18n, UI, and docs work undone by0e9218bd68Commit0e9218bd68silently reverted the following work alongside its stated sync/client-id changes. Files where later master commits (fec7b25f23, etc.) already re-applied the reverted work are intentionally left untouched. Restored: - #7232 docs/long-term-plans/location-based-reminders.md (513 lines) - #7199 Romanian i18n phase 3 (ro.json + ro-md.json, ~1168 lines) - #7049 Polish translation improvements - #7143 planner component styling (4 scss files) - #7211 add-task-bar preserve time estimate when typing title - #7208 task.reducer roll-up estimates for added subtasks - #6767 focus-mode pomodoro reset button - #7205 plugin-dev github-issue-provider TOKEN description - #7231 mobile-bottom-nav FAB fix -a4fe03272iOS keyboard accessory bar (global-theme + dialog-fullscreen-markdown) -309670db3ShortSyntaxEffects undefined guard -667a7986fDropbox PKCE auth comment/behavior * fix(electron): restore electron + e2e work undone by0e9218bd68Commit0e9218bd68silently reverted the following electron/e2e work. Files already re-fixed by later master commits are left as-is: - e2e/tests/sync/supersync-archive-conflict.spec.ts (de33234976+191d129ff3) Restored: -e8a3e156ebfix(electron): Linux autostart IDB backing-store recovery (re-adds electron/clear-stale-idb-locks.ts + start-app.ts wiring) -5ce78a5b63fix(electron): macOS Cmd+Q / Dock > Quit hang (setIsQuiting + before-quit delegate to close-handler) -46e0fa2d01fix(sync): FILE_SYNC_LIST_FILES IPC contract (electronAPI.d.ts + local-file-sync + preload + ipc-events) -ea1ef16307fix(android): session-only SAF permissions on OEM devices -8865dc0a50test(e2e): supersync parallel-worker stampede guard (SUPERSYNC_SERVER_HEALTHY env-var fallback + goto retry loop) -af7c7687e2test(e2e): block WS-triggered downloads in non-WS specs -265b44db5dtest(e2e): premature waitForURL on daily-summary (this is literally the fix the bad commit's message claimed to add) Conflict resolutions: - e2e/utils/supersync-helpers.ts: kept the refined getDoneTaskElement checks fromd64014d086(later thanc558bcab5e) while restoring the goto retry loop from8865dc0a50. - electron/start-app.ts: unioned imports (setIsQuiting + clearStaleLevelDbLocks from theirs, fs from ours). * fix(sync): restore sync-core work undone by0e9218bd68Commit0e9218bd68silently reverted parts of several sync fixes. Most sync-core reverts have already been re-addressed differently on master by later commits (1f5184f6e7,05cd875dd6,09f5ced2c9,7df43358ab,d9158d6adb,32dbc95ed9,8c3b08e016,f89fe1ebc3) — those files are intentionally left untouched to avoid reverting master's newer work. This PR restores only the pieces that are genuinely still missing: -e8a3e156ebfix(electron): IDB backing-store autoreload (in-app piece) operation-log-hydrator.service.ts + .spec.ts (the electron/clear- stale-idb-locks.ts piece was restored in the prior commit) Plus three low-risk documentation/cleanup restorations: - operation-sync.util.ts — add "Nextcloud" to isFileBasedProvider JSDoc - dropbox.ts — restore improved _getRedirectUri JSDoc (667a7986fb) - dialog-get-and-enter-auth-code.component.ts — restore isNativePlatform comment explaining why manual code entry flow is used (667a7986fb) - file-adapter.interface.ts — remove stray "// NEW" comment (46e0fa2d01) Intentionally NOT restored (master's newer work covers or supersedes): - sync-trigger.service.ts / sync.effects.ts (05cd875dd6) - sync-wrapper.service.ts (1f5184f6e7) - sync-errors.ts (1f5184f6e7re-added LegacySyncFormatDetectedError) - file-based-sync-adapter.service.ts + spec (1f5184f6e7+d9158d6adb) - file-based-sync.types.ts (1f5184f6e7) - operation-log.const.ts (32dbc95ed9bumped IDB_OPEN_RETRIES to 5) - dialog-sync-initial-cfg.component.ts (f89fe1ebc3)
235 lines
7.2 KiB
YAML
235 lines
7.2 KiB
YAML
name: 'E2E Tests (Scheduled)'
|
|
|
|
on:
|
|
schedule:
|
|
- cron: '0 2 * * *' # 2 AM UTC daily
|
|
|
|
workflow_dispatch:
|
|
|
|
push:
|
|
branches: [master, release/*]
|
|
paths:
|
|
- 'src/app/imex/sync/**'
|
|
- 'src/app/op-log/**'
|
|
- 'e2e/tests/**'
|
|
- 'docker-compose.yaml'
|
|
- 'docker-compose.supersync.yaml'
|
|
- 'packages/super-sync-server/**'
|
|
- 'packages/shared-schema/**'
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
# Job 0: Build frontend once and share artifact
|
|
build:
|
|
name: Build Frontend
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 15
|
|
env:
|
|
UNSPLASH_KEY: ${{ secrets.UNSPLASH_KEY }}
|
|
UNSPLASH_CLIENT_ID: ${{ secrets.UNSPLASH_CLIENT_ID }}
|
|
|
|
steps:
|
|
- name: Check out Git repository
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Setup E2E Environment
|
|
uses: ./.github/actions/setup-e2e
|
|
|
|
- run: npm run env
|
|
|
|
- name: Build Frontend for E2E
|
|
run: npm run buildFrontend:e2e
|
|
|
|
- name: Verify Build Output
|
|
run: |
|
|
test -f .tmp/angular-dist/browser/index.html || (echo "Build output missing" && exit 1)
|
|
test -f .tmp/angular-dist/browser/assets/bundled-plugins/api-test-plugin/manifest.json || (echo "Plugin assets missing from build" && exit 1)
|
|
|
|
- name: Upload Build Artifact
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: e2e-build-${{ github.run_id }}
|
|
path: .tmp/angular-dist
|
|
retention-days: 1
|
|
|
|
# Job 1: Regular E2E tests (excludes WebDAV and SuperSync)
|
|
e2e-regular:
|
|
name: E2E Tests (Regular)
|
|
needs: [build]
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 60
|
|
env:
|
|
UNSPLASH_KEY: ${{ secrets.UNSPLASH_KEY }}
|
|
UNSPLASH_CLIENT_ID: ${{ secrets.UNSPLASH_CLIENT_ID }}
|
|
|
|
steps:
|
|
- name: Check out Git repository
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Setup E2E Environment
|
|
uses: ./.github/actions/setup-e2e
|
|
|
|
- name: Download Build Artifact
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v4
|
|
with:
|
|
name: e2e-build-${{ github.run_id }}
|
|
path: .tmp/angular-dist
|
|
|
|
- name: Run Regular E2E Tests
|
|
run: npm run e2e:ci
|
|
|
|
- name: Upload E2E Results on Failure
|
|
if: ${{ failure() }}
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: e2e-results-regular-${{ github.run_id }}
|
|
path: .tmp/e2e-test-results/**/*.*
|
|
retention-days: 30
|
|
|
|
# Job 2: WebDAV E2E tests
|
|
e2e-webdav:
|
|
name: E2E Tests (WebDAV)
|
|
needs: [build]
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
env:
|
|
UNSPLASH_KEY: ${{ secrets.UNSPLASH_KEY }}
|
|
UNSPLASH_CLIENT_ID: ${{ secrets.UNSPLASH_CLIENT_ID }}
|
|
|
|
steps:
|
|
- name: Check out Git repository
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Setup E2E Environment
|
|
uses: ./.github/actions/setup-e2e
|
|
|
|
- name: Download Build Artifact
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v4
|
|
with:
|
|
name: e2e-build-${{ github.run_id }}
|
|
path: .tmp/angular-dist
|
|
|
|
- name: Create .env file for Docker Compose
|
|
run: |
|
|
cp .env.example .env
|
|
|
|
- name: Start WebDAV Docker Service
|
|
run: |
|
|
docker compose up -d webdav
|
|
chmod +x ./scripts/wait-for-webdav.sh
|
|
./scripts/wait-for-webdav.sh
|
|
|
|
- name: Run WebDAV E2E Tests
|
|
run: npm run e2e:all -- --grep "@webdav"
|
|
|
|
- name: Stop Docker Services
|
|
if: always()
|
|
run: |
|
|
docker compose down
|
|
|
|
- name: Print Docker Logs on Failure
|
|
if: ${{ failure() }}
|
|
run: |
|
|
echo "=== WebDAV Logs ==="
|
|
docker compose logs webdav
|
|
|
|
- name: Upload E2E Results on Failure
|
|
if: ${{ failure() }}
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: e2e-results-webdav-${{ github.run_id }}
|
|
path: .tmp/e2e-test-results/**/*.*
|
|
retention-days: 30
|
|
|
|
# Job 3: SuperSync E2E tests (sharded)
|
|
e2e-supersync:
|
|
name: E2E Tests (SuperSync ${{ matrix.shard }}/4)
|
|
needs: [build]
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 40
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
shard: [1, 2, 3, 4]
|
|
env:
|
|
UNSPLASH_KEY: ${{ secrets.UNSPLASH_KEY }}
|
|
UNSPLASH_CLIENT_ID: ${{ secrets.UNSPLASH_CLIENT_ID }}
|
|
|
|
steps:
|
|
- name: Check out Git repository
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Setup E2E Environment
|
|
uses: ./.github/actions/setup-e2e
|
|
|
|
- name: Download Build Artifact
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v4
|
|
with:
|
|
name: e2e-build-${{ github.run_id }}
|
|
path: .tmp/angular-dist
|
|
|
|
- name: Create .env file for Docker Compose
|
|
run: |
|
|
cp .env.example .env
|
|
|
|
- name: Start SuperSync Docker Service
|
|
run: |
|
|
docker compose -f docker-compose.yaml -f docker-compose.supersync.yaml up -d --build supersync
|
|
echo "⏳ Waiting for SuperSync server..."
|
|
until curl -s http://localhost:1901/health > /dev/null 2>&1; do sleep 1; done
|
|
echo "✓ SuperSync server ready!"
|
|
|
|
- name: Run SuperSync E2E Tests
|
|
run: npm run e2e:all -- --grep "@supersync" --shard=${{ matrix.shard }}/4
|
|
|
|
- name: Stop Docker Services
|
|
if: always()
|
|
run: |
|
|
docker compose -f docker-compose.yaml -f docker-compose.supersync.yaml down supersync
|
|
|
|
- name: Print Docker Logs on Failure
|
|
if: ${{ failure() }}
|
|
run: |
|
|
echo "=== SuperSync Logs ==="
|
|
docker compose -f docker-compose.yaml -f docker-compose.supersync.yaml logs supersync
|
|
|
|
- name: Upload E2E Results on Failure
|
|
if: ${{ failure() }}
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: e2e-results-supersync-${{ matrix.shard }}-${{ github.run_id }}
|
|
path: .tmp/e2e-test-results/**/*.*
|
|
retention-days: 30
|
|
|
|
# Job 4: SuperSync Server Unit Tests (runs in parallel with build, no artifact needed)
|
|
supersync-server-tests:
|
|
name: SuperSync Server Unit Tests
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 10
|
|
steps:
|
|
- name: Check out Git repository
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
|
|
with:
|
|
persist-credentials: false
|
|
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
|
|
with:
|
|
node-version: 22
|
|
cache: 'npm'
|
|
- name: Reconfigure git to use HTTP authentication
|
|
run: >
|
|
git config --global url."https://github.com/".insteadOf
|
|
ssh://git@github.com/
|
|
- name: Install npm Packages
|
|
run: npm i
|
|
- name: Run SuperSync Server Tests
|
|
run: cd packages/super-sync-server && npm test
|