super-productivity

mirror of https://github.com/johannesjo/super-productivity.git synced 2026-07-18 08:56:41 +00:00

History

Johannes Millan 19e2cbd63a test(notes): harden #8434 fix per multi-review Apply verified findings from a multi-agent review of the resize-close fix: - Guard the navigation listener on `dialogRef.getState() === OPEN`. A breakpoint-crossing resize can emit more than one popstate, and MatDialogRef.close() does not check its own state — a second call would re-run the exit animation and schedule a duplicate close timeout. The guard makes the second+ fires no-ops (the saved result still resolves once, so this was churn, not data loss). - Add unit tests asserting the navigation-close actually PERSISTS the edit (the point of #8434), both via `changed` when alive and via the direct dispatch after a breakpoint switch destroys the host (#8432), plus a test that a second popstate while closing does not re-close. - e2e: hover the notes area before clicking the opacity-hidden fullscreen control, matching the real user flow. - Tighten the duplicated explanatory comment. No behavior change to the fix itself. 77 inline-markdown unit tests and the note-resize e2e pass.	2026-06-17 16:07:54 +02:00
..
detail-fullscreen-note-resize.spec.ts	test(notes): harden #8434 fix per multi-review	2026-06-17 16:07:54 +02:00

Johannes Millan 19e2cbd63a test(notes): harden #8434 fix per multi-review

Apply verified findings from a multi-agent review of the resize-close fix:

- Guard the navigation listener on `dialogRef.getState() === OPEN`. A
  breakpoint-crossing resize can emit more than one popstate, and
  MatDialogRef.close() does not check its own state — a second call would
  re-run the exit animation and schedule a duplicate close timeout. The
  guard makes the second+ fires no-ops (the saved result still resolves
  once, so this was churn, not data loss).
- Add unit tests asserting the navigation-close actually PERSISTS the
  edit (the point of #8434), both via `changed` when alive and via the
  direct dispatch after a breakpoint switch destroys the host (#8432),
  plus a test that a second popstate while closing does not re-close.
- e2e: hover the notes area before clicking the opacity-hidden
  fullscreen control, matching the real user flow.
- Tighten the duplicated explanatory comment.

No behavior change to the fix itself. 77 inline-markdown unit tests and
the note-resize e2e pass.

2026-06-17 16:07:54 +02:00

detail-fullscreen-note-resize.spec.ts

test(notes): harden #8434 fix per multi-review

2026-06-17 16:07:54 +02:00