mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-18 17:05:48 +00:00
* test: harden e2e failure signals Fail otherwise-passing E2E tests on browser runtime errors, keep Playwright retries disabled, preserve Docker E2E exit codes, and make plugin/WebDAV setup failures hard failures instead of logged or skipped conditions. * test: harden provider e2e runners Make WebDAV and SuperSync runner scripts require provider readiness, preserve cleanup and argument forwarding, and fail manual sync clients on uncaught page errors. * ci: require providers for scheduled e2e Set required-provider flags in scheduled WebDAV and SuperSync jobs, and remove the duplicate provider runner scripts while keeping local npm aliases inline. * test: catch e2e teardown pageerrors and tighten fixture - closeClient now asserts runtime errors AFTER context.close() so pageerrors emitted during teardown (Angular destroy hooks, late RxJS errors) are captured instead of dropped. Matches the pattern in guardContextCloseWithRuntimeErrorCheck. - test.fixture.ts isolatedContext now spreads Playwright's merged contextOptions instead of destructuring 23 fields by hand. Future option additions propagate automatically; the page fixture uses the shared attachPageErrorCollector and only fails on pageerror (not console.error, which is too noisy). Guards against a configured 0 timeout being treated as undefined. - plugin-loading.spec.ts second test now hard-asserts that the plugin menu entry reappears after re-enable, matching the first test instead of silently logging when not visible. * test(sync): stabilize ImmediateUploadService spec Two complementary fixes for flaky failures observed under full-suite random-order runs where the upload pipeline silently never fires: - Pin navigator.onLine = true in beforeEach (restored in afterEach). isOnline() inside _canUpload reads navigator.onLine directly. The keyboard-layout spec replaces the whole navigator and the is-online spec spies on it; if order or restoration ever drifts, every "should fire upload" test fails trivially while the "should NOT" tests pass. - Replace tick(2100) with tick(2000); flush(). The await chain inside withSession() (provider.isReady, withSession entry, uploadPendingOps, optional LWW re-upload) requires more microtask drain than tick's fixed-time window reliably provides under load. flush() drains the pipeline regardless. * test(e2e): guard skipOnboarding init script against data: frames The new page-error collector started failing plugin specs because addInitScript runs in every frame — including the empty data:text/html iframe that plugin-index swaps in on destroy — and localStorage access in a data: URL throws SecurityError. Wrap the four setItem calls in try/catch so the helper noops in storage-less frames.
231 lines
8.1 KiB
TypeScript
231 lines
8.1 KiB
TypeScript
import { test, expect } from '../../fixtures/test.fixture';
|
|
import { cssSelectors } from '../../constants/selectors';
|
|
import {
|
|
waitForPluginAssets,
|
|
waitForPluginManagementInit,
|
|
getCITimeoutMultiplier,
|
|
enablePluginWithVerification,
|
|
disablePluginWithVerification,
|
|
} from '../../helpers/plugin-test.helpers';
|
|
|
|
const { SIDENAV } = cssSelectors;
|
|
|
|
// Plugin-related selectors
|
|
const PLUGIN_CARD = 'plugin-management mat-card.ng-star-inserted';
|
|
const PLUGIN_ITEM = `${PLUGIN_CARD}`;
|
|
const PLUGIN_NAV_ENTRIES = `${SIDENAV} nav-item button`;
|
|
const PLUGIN_IFRAME = 'plugin-index iframe';
|
|
|
|
test.describe.serial('Plugin Loading', () => {
|
|
test('full plugin loading lifecycle', async ({ page, workViewPage }) => {
|
|
const timeoutMultiplier = getCITimeoutMultiplier();
|
|
// Slightly higher base to avoid flakiness on slower environments
|
|
test.setTimeout(45000 * timeoutMultiplier);
|
|
|
|
// First, ensure plugin assets are available
|
|
const assetsAvailable = await waitForPluginAssets(page);
|
|
if (!assetsAvailable) {
|
|
throw new Error('Plugin assets not available - cannot proceed with test');
|
|
}
|
|
|
|
await workViewPage.waitForTaskList();
|
|
|
|
// Use improved plugin management init that handles navigation and setup
|
|
const pluginReady = await waitForPluginManagementInit(page);
|
|
if (!pluginReady) {
|
|
throw new Error('Plugin management could not be initialized');
|
|
}
|
|
|
|
// Enable the plugin
|
|
const enableResult = await page.evaluate((pluginName: string) => {
|
|
const cards = Array.from(document.querySelectorAll('plugin-management mat-card'));
|
|
const targetCard = cards.find((card) => {
|
|
const title = card.querySelector('mat-card-title')?.textContent || '';
|
|
return title.includes(pluginName);
|
|
});
|
|
|
|
if (targetCard) {
|
|
const toggleButton = targetCard.querySelector(
|
|
'mat-slide-toggle button[role="switch"]',
|
|
) as HTMLButtonElement;
|
|
if (toggleButton) {
|
|
const wasChecked = toggleButton.getAttribute('aria-checked') === 'true';
|
|
if (!wasChecked) {
|
|
toggleButton.click();
|
|
}
|
|
return {
|
|
enabled: true,
|
|
found: true,
|
|
wasChecked,
|
|
nowChecked: toggleButton.getAttribute('aria-checked') === 'true',
|
|
clicked: !wasChecked,
|
|
};
|
|
}
|
|
return { enabled: false, found: true, error: 'No toggle found' };
|
|
}
|
|
|
|
return { enabled: false, found: false };
|
|
}, 'API Test Plugin');
|
|
|
|
expect(enableResult.found).toBe(true);
|
|
|
|
// Wait for toggle state to change to enabled
|
|
if (enableResult.clicked) {
|
|
await page.waitForFunction(
|
|
(name) => {
|
|
const cards = Array.from(
|
|
document.querySelectorAll('plugin-management mat-card'),
|
|
);
|
|
const targetCard = cards.find((card) => {
|
|
const title = card.querySelector('mat-card-title')?.textContent || '';
|
|
return title.includes(name);
|
|
});
|
|
const toggle = targetCard?.querySelector(
|
|
'mat-slide-toggle button[role="switch"]',
|
|
) as HTMLButtonElement;
|
|
return toggle?.getAttribute('aria-checked') === 'true';
|
|
},
|
|
'API Test Plugin',
|
|
{ timeout: 10000 },
|
|
);
|
|
}
|
|
|
|
// Ensure plugin management is visible in viewport
|
|
await page.evaluate(() => {
|
|
const pluginMgmt = document.querySelector('plugin-management');
|
|
if (pluginMgmt) {
|
|
pluginMgmt.scrollIntoView({ behavior: 'instant', block: 'center' });
|
|
}
|
|
});
|
|
|
|
// Navigate to plugin management - check for attachment first
|
|
await expect(page.locator(PLUGIN_CARD).first()).toBeAttached({ timeout: 20000 });
|
|
|
|
// Check example plugin is loaded and enabled
|
|
const pluginCardsResult = await page.evaluate(() => {
|
|
const cards = Array.from(document.querySelectorAll('plugin-management mat-card'));
|
|
const pluginCards = cards.filter((card) => card.querySelector('mat-slide-toggle'));
|
|
return {
|
|
totalCards: cards.length,
|
|
pluginCardsCount: pluginCards.length,
|
|
pluginTitles: pluginCards.map(
|
|
(card) => card.querySelector('mat-card-title')?.textContent?.trim() || '',
|
|
),
|
|
};
|
|
});
|
|
|
|
expect(pluginCardsResult.pluginCardsCount).toBeGreaterThanOrEqual(1);
|
|
expect(pluginCardsResult.pluginTitles).toContain('API Test Plugin');
|
|
|
|
// Navigate back to work view to see plugin menu
|
|
await page.click('text=Today');
|
|
await page.waitForLoadState('networkidle');
|
|
await expect(page).toHaveURL(/\/#\/tag\/TODAY/);
|
|
|
|
// Verify plugin menu entry exists
|
|
const pluginNavItem = page
|
|
.locator(PLUGIN_NAV_ENTRIES)
|
|
.filter({ hasText: 'API Test Plugin' });
|
|
await expect(pluginNavItem).toBeVisible({ timeout: 15000 });
|
|
await expect(pluginNavItem).toContainText('API Test Plugin');
|
|
|
|
await pluginNavItem.click();
|
|
await expect(page.locator(PLUGIN_IFRAME)).toBeVisible({ timeout: 10000 });
|
|
await expect(page).toHaveURL(/\/plugins\/api-test-plugin\/index/);
|
|
|
|
// Switch to iframe context and verify content
|
|
const frame = page.frameLocator(PLUGIN_IFRAME);
|
|
await expect(frame.getByRole('heading', { name: 'API Test Plugin' })).toBeVisible({
|
|
timeout: 10000,
|
|
});
|
|
});
|
|
|
|
test('disable and re-enable plugin', async ({ page, workViewPage }) => {
|
|
// Increase timeout to account for asset checking and plugin (un)load
|
|
test.setTimeout(process.env.CI ? 90000 : 60000);
|
|
|
|
// Check if plugin assets are available
|
|
const assetsAvailable = await waitForPluginAssets(page);
|
|
if (!assetsAvailable) {
|
|
throw new Error('Plugin assets not available - cannot proceed with test');
|
|
}
|
|
|
|
await workViewPage.waitForTaskList();
|
|
|
|
// Use improved plugin management init that handles navigation and setup
|
|
const pluginReady = await waitForPluginManagementInit(page);
|
|
if (!pluginReady) {
|
|
throw new Error('Plugin management could not be initialized');
|
|
}
|
|
|
|
// Enable the plugin first using the helper function
|
|
const enableResult = await enablePluginWithVerification(
|
|
page,
|
|
'API Test Plugin',
|
|
15000,
|
|
);
|
|
expect(enableResult).toBe(true);
|
|
|
|
// Wait for plugin card to be stable before disabling
|
|
await page.waitForTimeout(500);
|
|
|
|
// Ensure plugin management is still visible and scroll to it
|
|
await page.evaluate(() => {
|
|
const pluginMgmt = document.querySelector('plugin-management');
|
|
if (pluginMgmt) {
|
|
pluginMgmt.scrollIntoView({ behavior: 'instant', block: 'center' });
|
|
}
|
|
});
|
|
|
|
// Navigate to plugin management - check for attachment
|
|
await expect(page.locator(PLUGIN_ITEM).first()).toBeAttached({ timeout: 10000 });
|
|
|
|
// Wait a bit for any animations to complete
|
|
await page.waitForTimeout(300);
|
|
|
|
// Disable the plugin using the helper function
|
|
const disableResult = await disablePluginWithVerification(
|
|
page,
|
|
'API Test Plugin',
|
|
15000,
|
|
);
|
|
|
|
// If disable failed, try reinitializing plugin management and retry
|
|
if (!disableResult) {
|
|
console.log('[Plugin Test] First disable attempt failed, retrying...');
|
|
const retryReady = await waitForPluginManagementInit(page);
|
|
if (retryReady) {
|
|
const retryDisable = await disablePluginWithVerification(
|
|
page,
|
|
'API Test Plugin',
|
|
15000,
|
|
);
|
|
expect(retryDisable).toBe(true);
|
|
} else {
|
|
expect(disableResult).toBe(true); // Will fail with original error
|
|
}
|
|
}
|
|
|
|
// Wait for disable to take effect
|
|
await page.waitForTimeout(500);
|
|
|
|
// Re-enable the plugin using the helper function
|
|
const reEnableResult = await enablePluginWithVerification(
|
|
page,
|
|
'API Test Plugin',
|
|
15000,
|
|
);
|
|
expect(reEnableResult).toBe(true);
|
|
|
|
// Navigate back to main view
|
|
await page.click('text=Today'); // Click on Today navigation
|
|
await expect(page).toHaveURL(/\/#\/tag\/TODAY/, { timeout: 10000 });
|
|
|
|
// Menu entry should reappear after re-enable
|
|
const pluginNavItemReEnabled = page
|
|
.locator(PLUGIN_NAV_ENTRIES)
|
|
.filter({ hasText: 'API Test Plugin' });
|
|
await expect(pluginNavItemReEnabled).toBeVisible({ timeout: 15000 });
|
|
await expect(pluginNavItemReEnabled).toContainText('API Test Plugin');
|
|
});
|
|
});
|