mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-18 17:05:48 +00:00
* test: harden e2e failure signals Fail otherwise-passing E2E tests on browser runtime errors, keep Playwright retries disabled, preserve Docker E2E exit codes, and make plugin/WebDAV setup failures hard failures instead of logged or skipped conditions. * test: harden provider e2e runners Make WebDAV and SuperSync runner scripts require provider readiness, preserve cleanup and argument forwarding, and fail manual sync clients on uncaught page errors. * ci: require providers for scheduled e2e Set required-provider flags in scheduled WebDAV and SuperSync jobs, and remove the duplicate provider runner scripts while keeping local npm aliases inline. * test: catch e2e teardown pageerrors and tighten fixture - closeClient now asserts runtime errors AFTER context.close() so pageerrors emitted during teardown (Angular destroy hooks, late RxJS errors) are captured instead of dropped. Matches the pattern in guardContextCloseWithRuntimeErrorCheck. - test.fixture.ts isolatedContext now spreads Playwright's merged contextOptions instead of destructuring 23 fields by hand. Future option additions propagate automatically; the page fixture uses the shared attachPageErrorCollector and only fails on pageerror (not console.error, which is too noisy). Guards against a configured 0 timeout being treated as undefined. - plugin-loading.spec.ts second test now hard-asserts that the plugin menu entry reappears after re-enable, matching the first test instead of silently logging when not visible. * test(sync): stabilize ImmediateUploadService spec Two complementary fixes for flaky failures observed under full-suite random-order runs where the upload pipeline silently never fires: - Pin navigator.onLine = true in beforeEach (restored in afterEach). isOnline() inside _canUpload reads navigator.onLine directly. The keyboard-layout spec replaces the whole navigator and the is-online spec spies on it; if order or restoration ever drifts, every "should fire upload" test fails trivially while the "should NOT" tests pass. - Replace tick(2100) with tick(2000); flush(). The await chain inside withSession() (provider.isReady, withSession entry, uploadPendingOps, optional LWW re-upload) requires more microtask drain than tick's fixed-time window reliably provides under load. flush() drains the pipeline regardless. * test(e2e): guard skipOnboarding init script against data: frames The new page-error collector started failing plugin specs because addInitScript runs in every frame — including the empty data:text/html iframe that plugin-index swaps in on destroy — and localStorage access in a data: URL throws SecurityError. Wrap the four setItem calls in try/catch so the helper noops in storage-less frames.
126 lines
4.3 KiB
TypeScript
126 lines
4.3 KiB
TypeScript
import { test, expect } from '../../fixtures/test.fixture';
|
|
import { cssSelectors } from '../../constants/selectors';
|
|
import {
|
|
waitForPluginAssets,
|
|
waitForPluginManagementInit,
|
|
enablePluginWithVerification,
|
|
waitForPluginInMenu,
|
|
disablePluginWithVerification,
|
|
getCITimeoutMultiplier,
|
|
} from '../../helpers/plugin-test.helpers';
|
|
|
|
const { SIDENAV } = cssSelectors;
|
|
|
|
// Plugin-related selectors
|
|
const API_TEST_PLUGIN_NAV_ITEM = `${SIDENAV} nav-item button:has-text("API Test Plugin")`;
|
|
const TIMEOUT_MULTIPLIER = getCITimeoutMultiplier();
|
|
const TEST_TIMEOUT_MS = 30000 * TIMEOUT_MULTIPLIER;
|
|
|
|
test.describe('Plugin Lifecycle', () => {
|
|
test.beforeEach(async ({ page, workViewPage }) => {
|
|
test.setTimeout(TEST_TIMEOUT_MS);
|
|
|
|
// First, ensure plugin assets are available
|
|
const assetsAvailable = await waitForPluginAssets(page);
|
|
if (!assetsAvailable) {
|
|
throw new Error('Plugin assets not available - cannot proceed with test');
|
|
}
|
|
|
|
await workViewPage.waitForTaskList();
|
|
|
|
// Navigate to settings and initialize plugin management
|
|
const initSuccess = await waitForPluginManagementInit(page);
|
|
if (!initSuccess) {
|
|
throw new Error(
|
|
'Plugin management failed to initialize (timeout waiting for plugin cards)',
|
|
);
|
|
}
|
|
|
|
const enabled = await enablePluginWithVerification(
|
|
page,
|
|
'API Test Plugin',
|
|
10000 * TIMEOUT_MULTIPLIER,
|
|
);
|
|
expect(enabled).toBe(true);
|
|
|
|
const pluginVisible = await waitForPluginInMenu(
|
|
page,
|
|
'API Test Plugin',
|
|
15000 * TIMEOUT_MULTIPLIER,
|
|
);
|
|
expect(pluginVisible).toBe(true);
|
|
});
|
|
|
|
test('verify plugin is initially loaded', async ({ page }) => {
|
|
test.setTimeout(TEST_TIMEOUT_MS);
|
|
// Wait for magic-side-nav to be ready
|
|
await page.locator(SIDENAV).waitFor({ state: 'visible' });
|
|
|
|
// Plugin doesn't show snack bar on load, check plugin nav item instead
|
|
await expect(page.locator(API_TEST_PLUGIN_NAV_ITEM)).toBeVisible({ timeout: 10000 });
|
|
await expect(page.locator(API_TEST_PLUGIN_NAV_ITEM)).toContainText('API Test Plugin');
|
|
});
|
|
|
|
test('test plugin navigation', async ({ page }) => {
|
|
test.setTimeout(TEST_TIMEOUT_MS);
|
|
|
|
// Click on the plugin nav item to navigate to plugin
|
|
const pluginNavItem = page.locator(API_TEST_PLUGIN_NAV_ITEM);
|
|
await expect(pluginNavItem).toBeVisible({ timeout: 10000 });
|
|
await Promise.all([
|
|
page.waitForURL(/\/plugins\/api-test-plugin\/index/, { timeout: 15000 }),
|
|
pluginNavItem.click(),
|
|
]);
|
|
|
|
// Verify we navigated to the plugin page
|
|
await expect(page).toHaveURL(/\/plugins\/api-test-plugin\/index/, { timeout: 10000 });
|
|
|
|
// Wait for Angular component initialization after navigation
|
|
await expect(async () => {
|
|
const iframe = page.locator('iframe');
|
|
await expect(iframe).toBeAttached({ timeout: 2000 });
|
|
await expect(iframe).toBeVisible({ timeout: 2000 });
|
|
}).toPass({ timeout: 10000, intervals: [500, 1000] });
|
|
|
|
// Go back to work view
|
|
await page.goto('/#/tag/TODAY/tasks');
|
|
});
|
|
|
|
test('disable plugin and verify cleanup', async ({ page }) => {
|
|
test.setTimeout(TEST_TIMEOUT_MS);
|
|
|
|
// Navigate to settings and set up plugin management view
|
|
const initSuccess = await waitForPluginManagementInit(page);
|
|
if (!initSuccess) {
|
|
throw new Error('Plugin management failed to re-initialize for disable test');
|
|
}
|
|
|
|
const disabled = await disablePluginWithVerification(
|
|
page,
|
|
'API Test Plugin',
|
|
10000 * TIMEOUT_MULTIPLIER,
|
|
);
|
|
expect(disabled).toBe(true);
|
|
|
|
// Go back to work view
|
|
await page.goto('/#/tag/TODAY/tasks');
|
|
// Wait for navigation and work view to be ready
|
|
await page.locator('.route-wrapper').waitFor({ state: 'visible', timeout: 10000 });
|
|
|
|
// Check if the magic-side-nav exists and verify the API Test Plugin is not in it
|
|
const sideNavExists = (await page.locator(SIDENAV).count()) > 0;
|
|
|
|
if (sideNavExists) {
|
|
const hasApiTestPlugin = await page.evaluate(() => {
|
|
const menuItems = Array.from(
|
|
document.querySelectorAll('magic-side-nav nav-item button'),
|
|
);
|
|
return menuItems.some((item) => item.textContent?.includes('API Test Plugin'));
|
|
});
|
|
|
|
expect(hasApiTestPlugin).toBe(false);
|
|
} else {
|
|
expect(sideNavExists).toBe(true);
|
|
}
|
|
});
|
|
});
|