mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-18 08:56:41 +00:00
77f83c5687
* test: harden e2e failure signals Fail otherwise-passing E2E tests on browser runtime errors, keep Playwright retries disabled, preserve Docker E2E exit codes, and make plugin/WebDAV setup failures hard failures instead of logged or skipped conditions. * test: harden provider e2e runners Make WebDAV and SuperSync runner scripts require provider readiness, preserve cleanup and argument forwarding, and fail manual sync clients on uncaught page errors. * ci: require providers for scheduled e2e Set required-provider flags in scheduled WebDAV and SuperSync jobs, and remove the duplicate provider runner scripts while keeping local npm aliases inline. * test: catch e2e teardown pageerrors and tighten fixture - closeClient now asserts runtime errors AFTER context.close() so pageerrors emitted during teardown (Angular destroy hooks, late RxJS errors) are captured instead of dropped. Matches the pattern in guardContextCloseWithRuntimeErrorCheck. - test.fixture.ts isolatedContext now spreads Playwright's merged contextOptions instead of destructuring 23 fields by hand. Future option additions propagate automatically; the page fixture uses the shared attachPageErrorCollector and only fails on pageerror (not console.error, which is too noisy). Guards against a configured 0 timeout being treated as undefined. - plugin-loading.spec.ts second test now hard-asserts that the plugin menu entry reappears after re-enable, matching the first test instead of silently logging when not visible. * test(sync): stabilize ImmediateUploadService spec Two complementary fixes for flaky failures observed under full-suite random-order runs where the upload pipeline silently never fires: - Pin navigator.onLine = true in beforeEach (restored in afterEach). isOnline() inside _canUpload reads navigator.onLine directly. The keyboard-layout spec replaces the whole navigator and the is-online spec spies on it; if order or restoration ever drifts, every "should fire upload" test fails trivially while the "should NOT" tests pass. - Replace tick(2100) with tick(2000); flush(). The await chain inside withSession() (provider.isReady, withSession entry, uploadPendingOps, optional LWW re-upload) requires more microtask drain than tick's fixed-time window reliably provides under load. flush() drains the pipeline regardless. * test(e2e): guard skipOnboarding init script against data: frames The new page-error collector started failing plugin specs because addInitScript runs in every frame — including the empty data:text/html iframe that plugin-index swaps in on destroy — and localStorage access in a data: URL throws SecurityError. Wrap the four setItem calls in try/catch so the helper noops in storage-less frames.
70 lines
2.2 KiB
TypeScript
70 lines
2.2 KiB
TypeScript
import { expect, test } from '../../fixtures/test.fixture';
|
|
import {
|
|
enablePluginWithVerification,
|
|
getCITimeoutMultiplier,
|
|
waitForPluginAssets,
|
|
waitForPluginInMenu,
|
|
waitForPluginManagementInit,
|
|
} from '../../helpers/plugin-test.helpers';
|
|
|
|
test.describe.serial('Plugin Enable Verify', () => {
|
|
test('enable API Test Plugin and verify menu entry', async ({ page, workViewPage }) => {
|
|
const timeoutMultiplier = getCITimeoutMultiplier();
|
|
test.setTimeout(30000 * timeoutMultiplier);
|
|
|
|
// First, ensure plugin assets are available
|
|
const assetsAvailable = await waitForPluginAssets(page);
|
|
if (!assetsAvailable) {
|
|
throw new Error('Plugin assets not available - cannot proceed with test');
|
|
}
|
|
|
|
await workViewPage.waitForTaskList();
|
|
|
|
// Navigate to settings and initialize plugin management
|
|
const initSuccess = await waitForPluginManagementInit(page);
|
|
if (!initSuccess) {
|
|
throw new Error(
|
|
'Plugin management failed to initialize (timeout waiting for plugin cards)',
|
|
);
|
|
}
|
|
|
|
// Plugin management is now visible - enable API Test Plugin
|
|
const pluginEnabled = await enablePluginWithVerification(
|
|
page,
|
|
'API Test Plugin',
|
|
10000 * timeoutMultiplier,
|
|
);
|
|
|
|
expect(pluginEnabled).toBe(true);
|
|
|
|
// Wait for plugin to appear in menu
|
|
const pluginInMenu = await waitForPluginInMenu(
|
|
page,
|
|
'API Test Plugin',
|
|
15000 * timeoutMultiplier,
|
|
);
|
|
|
|
expect(pluginInMenu).toBe(true);
|
|
|
|
// Additional verification - check menu structure in magic-side-nav
|
|
const menuResult = await page.evaluate(() => {
|
|
const sideNav = document.querySelector('magic-side-nav');
|
|
const navButtons = sideNav
|
|
? Array.from(sideNav.querySelectorAll('nav-item button'))
|
|
: [];
|
|
|
|
return {
|
|
hasSideNav: !!sideNav,
|
|
buttonCount: navButtons.length,
|
|
buttonTexts: navButtons.map((btn) => btn.textContent?.trim() || ''),
|
|
};
|
|
});
|
|
|
|
expect(menuResult.hasSideNav).toBe(true);
|
|
expect(menuResult.buttonCount).toBeGreaterThan(0);
|
|
const hasApiTestPlugin = menuResult.buttonTexts.some((text: string) =>
|
|
text.includes('API Test Plugin'),
|
|
);
|
|
expect(hasApiTestPlugin).toBe(true);
|
|
});
|
|
});
|