Commit graph

3 commits

Author SHA1 Message Date
Johannes Millan
23579a448a fix(shared-schema): use tsup for dual ESM/CJS build
The previous commit changed module resolution to bundler mode which
fixed Angular tests but broke Node.js ESM imports in super-sync-server.

Switch to tsup bundler that outputs both ESM (.mjs) and CJS (.js) formats,
with proper exports field to support both environments:
- CJS for super-sync-server (Node.js commonjs)
- ESM for Angular/webpack bundler imports
2026-01-11 14:05:23 +01:00
Johannes Millan
615188bf88 fix: address code review findings from last 24 hours
1. Fix race condition in replaceToken (auth.ts)
   - Wrap UPDATE and SELECT in transaction for atomicity

2. Fix mutex memory leak in operation-log-hydrator
   - Add explicit error logging before rethrowing in repair promise

3. Improve global mutable state handling (is-related-model-data-valid.ts)
   - Reset lastValidityError at start of each validation
   - Add documentation warning about the pattern

4. Fix version tracking bug in shared-schema migration
   - Update version inside try block so migratedToVersion reflects
     where we actually stopped, even if operation was dropped

5. Remove unused import validateMigrationRegistry (sync.service.ts)

6. Add array payload rejection test (validate-operation-payload.spec.ts)

7. Add lock service contention tests (lock.service.spec.ts)
   - Tests for corrupted lock formats (no timestamp, NaN, empty string)

Also includes shared-schema ESM configuration:
- Add "type": "module" to package.json for ESM output
- Change module/moduleResolution to NodeNext in tsconfig.json
- Add .js extensions to all relative imports (required by Node.js ESM)
2025-12-12 20:47:47 +01:00
Johannes Millan
8dc8207da2 feat(sync): add shared schema versioning package for frontend/backend
Create @sp/shared-schema package with pure TypeScript migration functions
that work in both Angular frontend and Node.js backend environments.

Package contents:
- schema-version.ts: Version constants (CURRENT=1, MAX_SKIP=3)
- migration.types.ts: OperationLike, SchemaMigration interfaces
- migrate.ts: Pure functions (migrateState, migrateOperation, etc.)
- migrations/index.ts: Empty migrations array (ready for first migration)
- 22 unit tests covering all migration scenarios

Backend changes:
- Add snapshot_schema_version column to user_sync_state table
- Migrate snapshots during generateSnapshot if outdated
- Migrate operations during replayOpsToState if outdated
- Drop operations that return null from migration (removed features)

Frontend changes:
- Refactor SchemaMigrationService to use @sp/shared-schema
- Re-export constants for backwards compatibility
- All 20 existing tests pass

This enables coordinated schema migrations across client and server,
ensuring old snapshots and operations can be upgraded when the state
structure changes.

Rollout strategy: Deploy backend first, then frontend.
2025-12-12 20:47:44 +01:00