Commit graph

3 commits

Author SHA1 Message Date
Johannes Millan
9bfbc06b18 chore: address code review feedback
- Fix misleading comment in sync-wrapper.service.ts safeguard
- Add missing SCSS for pause-resume button in focus mode break
- Remove commented archive store code from feature-stores.module.ts
- Increase touch submenu test buffer from 350ms to 450ms for CI stability
- Remove redundant isEmojiIcon method in tag-toggle-menu-list component
2026-01-15 10:57:43 +01:00
Johannes Millan
c6028b980d fix(e2e): stabilize flaky menu-touch-submenu test
Replace arbitrary waitForTimeout calls with condition-based waiting:
- Use specific selector scoped to .mat-mdc-menu-content for tag button
- Wait for tag to appear on task instead of waiting for menu to close
- Keep only the justified 350ms wait for touch protection delay testing
2026-01-14 13:45:27 +01:00
Johannes Millan
4ffad50f34 fix(menu): update touch monkey patch for Angular Material 21
The monkey patch that prevents accidental submenu selection on touch
devices was broken after the Angular Material 21 update.

Root cause: Angular Material renamed MatMenuItem._handleClick to
_checkDisabled in version 21.

Changes:
- Update patch to override _checkDisabled instead of _handleClick
- Add unit tests to detect future Angular Material API changes
- Add e2e tests for context menu submenu functionality
- Document API dependencies and change history in code comments

Fixes touch devices accidentally selecting menu items when submenus
open under the user's finger near screen edges.

Issue: #4436
2026-01-13 18:26:45 +01:00