Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-07-17 16:37:43 +00:00
Code Issues Projects Releases Wiki Activity

test(e2e): fix flaky import-sync tests with proper app readiness waits

Browse source 
Replace waitForLoadState('networkidle') with waitForAppReady() after
post-import page reloads and before task count verification. networkidle
only waits for network silence but not Angular bootstrap, loading
screens, or blocking dialogs - causing intermittent failures under load.
This commit is contained in:
Johannes Millan 2026-02-13 12:18:47 +01:00
parent d6a6ea1f12
commit fda5bca5b3
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
e2e/tests/sync/import-sync.spec.ts
View file

@ -97,7 +97,7 @@ base.describe('@importsync @supersync Import + Sync E2E', () => {
waitUntil: 'domcontentloaded',
timeout: 30000,
});
await clientA.page.waitForLoadState('networkidle');
await waitForAppReady(clientA.page);
// Wait for import to complete and verify tasks are visible
// The backup contains tasks with "E2E Import Test" in their titles
@ -195,11 +195,15 @@ base.describe('@importsync @supersync Import + Sync E2E', () => {
// ============ PHASE 6: Final Verification ============
console.log('[Import Test] Phase 6: Final state verification');
// Go back to work view on both clients
// Go back to work view on both clients and wait for app to be ready
await clientA.page.goto('/#/tag/TODAY/tasks');
await clientA.page.waitForLoadState('networkidle');
await waitForAppReady(clientA.page);
await clientB.page.goto('/#/tag/TODAY/tasks');
await clientB.page.waitForLoadState('networkidle');
await waitForAppReady(clientB.page);
// Wait for tasks to render before counting
await waitForTask(clientA.page, 'E2E Import Test - Active Task With Subtask');
await waitForTask(clientB.page, 'E2E Import Test - Active Task With Subtask');
// Count tasks on both clients - should match
const taskCountA = await clientA.page.locator('task').count();
@ -298,7 +302,7 @@ base.describe('@importsync @supersync Import + Sync E2E', () => {
waitUntil: 'domcontentloaded',
timeout: 30000,
});
await clientA.page.waitForLoadState('networkidle');
await waitForAppReady(clientA.page);
// Re-enable sync after import (import overwrites globalConfig including sync settings)
console.log('[Merge Test] Re-enabling sync after import');