From f56b5c584aa0503cd308b3fe44058657aa935d88 Mon Sep 17 00:00:00 2001
From: Simran Gill <simran.gill@gmail.com>
Date: Fri, 10 Jan 2025 18:15:22 -0800
Subject: [PATCH] Refactored plannedAt implementation as per feedback

---
 .swp                                          | Bin 0 -> 12288 bytes
 src/app/features/issue/issue.model.ts         |  32 +++++++++---------
 src/app/features/issue/issue.service.ts       |   6 ----
 .../open-project-common-interfaces.service.ts |   6 ++++
 4 files changed, 22 insertions(+), 22 deletions(-)
 create mode 100644 .swp

diff --git a/.swp b/.swp
new file mode 100644
index 0000000000000000000000000000000000000000..570a327aed75ab14d7e802f82780d0d596e92b62
GIT binary patch
literal 12288
zcmeI%y$*sf6o%o0o0CT4#sE5Fs4nbI3?>d>TroH}_!DIJPPr6ft1@;Yba|V!O=;8b
z<k=d|@iE;8$y$kSQ#1UUzYuv{Z&h*czS!s8qq;-~6{Xq9euy0e5O6Fo&bJ#Cn<7@r
zFqqGB$Mq1800IagfB*srAb<b@LkiSSPu@Ck^bhqc^N=->g#ZEwAb<b@2q1s}0tg_0
v00R9A6s1Tr5ovWd|Np!9|99PQ6t^LO00IagfB*srAb<b@2q1uf6M<Sj!mJQD

literal 0
HcmV?d00001

diff --git a/src/app/features/issue/issue.model.ts b/src/app/features/issue/issue.model.ts
index dfb36ec8c..266909727 100644
--- a/src/app/features/issue/issue.model.ts
+++ b/src/app/features/issue/issue.model.ts
@@ -85,32 +85,32 @@ export type IssueData =
   | RedmineIssue;
 
 export type IssueDataReduced =
-  | (GithubIssueReduced & { plannedAt?: string | null })
-  | (JiraIssueReduced & { plannedAt?: string | null })
-  | (GitlabIssue & { plannedAt?: string | null })
-  | (OpenProjectWorkPackageReduced & { plannedAt?: string | null })
-  | (CaldavIssueReduced & { plannedAt?: string | null })
-  | (ICalIssueReduced & { plannedAt?: string | null })
-  | (GiteaIssue & { plannedAt?: string | null })
-  | (RedmineIssue & { plannedAt?: string | null });
+  | GithubIssueReduced
+  | JiraIssueReduced
+  | GitlabIssue
+  | OpenProjectWorkPackageReduced
+  | CaldavIssueReduced
+  | ICalIssueReduced
+  | GiteaIssue
+  | RedmineIssue;
 
 export type IssueDataReducedMap = {
   [K in IssueProviderKey]: K extends 'JIRA'
-    ? JiraIssueReduced & { plannedAt?: string | null }
+    ? JiraIssueReduced
     : K extends 'GITHUB'
-      ? GithubIssueReduced & { plannedAt?: string | null }
+      ? GithubIssueReduced
       : K extends 'GITLAB'
-        ? GitlabIssue & { plannedAt?: string | null }
+        ? GitlabIssue
         : K extends 'CALDAV'
-          ? CaldavIssueReduced & { plannedAt?: string | null }
+          ? CaldavIssueReduced
           : K extends 'ICAL'
-            ? ICalIssueReduced & { plannedAt?: string | null }
+            ? ICalIssueReduced
             : K extends 'OPEN_PROJECT'
-              ? OpenProjectWorkPackageReduced & { plannedAt?: string | null }
+              ? OpenProjectWorkPackageReduced
               : K extends 'GITEA'
-                ? GiteaIssue & { plannedAt?: string | null }
+                ? GiteaIssue
                 : K extends 'REDMINE'
-                  ? RedmineIssue & { plannedAt?: string | null }
+                  ? RedmineIssue
                   : never;
 };
 
diff --git a/src/app/features/issue/issue.service.ts b/src/app/features/issue/issue.service.ts
index 0f5692af2..fc3c75ad0 100644
--- a/src/app/features/issue/issue.service.ts
+++ b/src/app/features/issue/issue.service.ts
@@ -454,18 +454,12 @@ export class IssueService {
       }
     };
 
-    const oneDayInMilliseconds = 24 * 60 * 60 * 1000;
-
     const taskData = {
       issueType: issueProviderKey,
       issueProviderId: issueProviderId,
       issueId: issueDataReduced.id.toString(),
       issueWasUpdated: false,
       issueLastUpdated: Date.now(),
-      plannedAt: issueDataReduced.plannedAt
-        ? new Date(new Date(issueDataReduced.plannedAt).setHours(6, 0, 0, 0)).getTime() +
-          oneDayInMilliseconds
-        : null, // Adjust plannedAt to 6 AM or set it to null if not present
       ...additionalFromProviderIssueService,
       // NOTE: if we were to add tags, this could be overwritten here
       ...(await getProjectOrTagId()),
diff --git a/src/app/features/issue/providers/open-project/open-project-common-interfaces.service.ts b/src/app/features/issue/providers/open-project/open-project-common-interfaces.service.ts
index e14d8c575..3341029e4 100644
--- a/src/app/features/issue/providers/open-project/open-project-common-interfaces.service.ts
+++ b/src/app/features/issue/providers/open-project/open-project-common-interfaces.service.ts
@@ -132,6 +132,8 @@ export class OpenProjectCommonInterfacesService implements IssueServiceInterface
     });
   }
 
+  readonly oneDayInMilliseconds = 24 * 60 * 60 * 1000;
+
   getAddTaskData(
     issue: OpenProjectWorkPackageReduced,
   ): Partial<Task> & { title: string } {
@@ -144,6 +146,10 @@ export class OpenProjectCommonInterfacesService implements IssueServiceInterface
       issuePoints: issue.storyPoints,
       issueWasUpdated: false,
       // NOTE: we use Date.now() instead to because updated does not account for comments
+      plannedAt: issue.plannedAt
+        ? new Date(new Date(issue.plannedAt).setHours(7, 30, 0, 0)).getTime() +
+          this.oneDayInMilliseconds
+        : null, // Adjust plannedAt to 7 AM or set it to null if not present
       issueLastUpdated: new Date(issue.updatedAt).getTime(),
       ...(parsedEstimate > 0 ? { timeEstimate: parsedEstimate } : {}),
     };