From f53bd27bb2fc68f392be98ff460013f05ee6cbc2 Mon Sep 17 00:00:00 2001
From: Johannes Millan <johannes.millan@gmail.com>
Date: Fri, 1 Aug 2025 12:50:03 +0200
Subject: [PATCH] fix: only show non inbox projects for hide and show

Closes #4883
---
 src/app/core-ui/side-nav/side-nav.component.html    |  2 +-
 src/app/core-ui/side-nav/side-nav.component.ts      | 10 ++++++----
 src/app/features/project/store/project.selectors.ts |  3 +++
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/app/core-ui/side-nav/side-nav.component.html b/src/app/core-ui/side-nav/side-nav.component.html
index ecfab1a3c2..32d6f3f08b 100644
--- a/src/app/core-ui/side-nav/side-nav.component.html
+++ b/src/app/core-ui/side-nav/side-nav.component.html
@@ -100,7 +100,7 @@
       [rightClickTriggerEl]="projectExpandBtn"
     ></context-menu>
     <ng-template #contextMenu>
-      @for (project of allProjects$ | async; track project.id) {
+      @for (project of allNonInboxProjects$ | async; track project.id) {
         <button
           mat-menu-item
           (click)="toggleProjectVisibility(project)"
diff --git a/src/app/core-ui/side-nav/side-nav.component.ts b/src/app/core-ui/side-nav/side-nav.component.ts
index 20fefda160..a67cd1b7c8 100644
--- a/src/app/core-ui/side-nav/side-nav.component.ts
+++ b/src/app/core-ui/side-nav/side-nav.component.ts
@@ -1,6 +1,7 @@
 import {
   ChangeDetectionStrategy,
   Component,
+  effect,
   ElementRef,
   HostBinding,
   HostListener,
@@ -8,7 +9,6 @@ import {
   OnDestroy,
   viewChild,
   viewChildren,
-  effect,
 } from '@angular/core';
 import { ProjectService } from '../../features/project/project.service';
 import { T } from '../../t.const';
@@ -37,14 +37,14 @@ import { LS } from '../../core/persistence/storage-keys.const';
 import { TODAY_TAG } from '../../features/tag/tag.const';
 import { TourId } from '../../features/shepherd/shepherd-steps.const';
 import { ShepherdService } from '../../features/shepherd/shepherd.service';
-import { getGithubErrorUrl } from 'src/app/core/error-handler/global-error-handler.util';
+import { getGithubErrorUrl } from '../../core/error-handler/global-error-handler.util';
 import { IS_MOUSE_PRIMARY, IS_TOUCH_PRIMARY } from '../../util/is-mouse-primary';
 import { GlobalConfigService } from '../../features/config/global-config.service';
 import { CdkDrag, CdkDragDrop, CdkDropList } from '@angular/cdk/drag-drop';
 import { moveItemBeforeItem } from '../../util/move-item-before-item';
 import { Store } from '@ngrx/store';
 import {
-  selectAllProjects,
+  selectAllProjectsExceptInbox,
   selectUnarchivedHiddenProjectIds,
   selectUnarchivedVisibleProjects,
 } from '../../features/project/store/project.selectors';
@@ -107,7 +107,9 @@ export class SideNavComponent implements OnDestroy {
     this.isProjectsExpanded,
   );
 
-  allProjects$: Observable<Project[]> = this._store.select(selectAllProjects);
+  allNonInboxProjects$: Observable<Project[]> = this._store.select(
+    selectAllProjectsExceptInbox,
+  );
   nonHiddenProjects$: Observable<Project[]> = this.isProjectsExpanded$.pipe(
     switchMap((isExpanded) =>
       isExpanded
diff --git a/src/app/features/project/store/project.selectors.ts b/src/app/features/project/store/project.selectors.ts
index 6a66750aa6..63f628d0a9 100644
--- a/src/app/features/project/store/project.selectors.ts
+++ b/src/app/features/project/store/project.selectors.ts
@@ -8,6 +8,9 @@ export const selectProjectFeatureState =
   createFeatureSelector<ProjectState>(PROJECT_FEATURE_NAME);
 const { selectAll } = projectAdapter.getSelectors();
 export const selectAllProjects = createSelector(selectProjectFeatureState, selectAll);
+export const selectAllProjectsExceptInbox = createSelector(selectAllProjects, (ps) =>
+  ps.filter((p) => p.id !== INBOX_PROJECT.id),
+);
 export const selectUnarchivedProjects = createSelector(selectAllProjects, (projects) =>
   projects.filter((p) => !p.isArchived),
 );