Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-01-23 02:36:05 +00:00
Code Issues Projects Releases Wiki Activity

fix(test): improve e2e sync test stability

Browse source 
- Add settle delays after bulk task creation for UI/NgRx processing
- Wait for done button visibility before clicking
- Use toPass() retry pattern for CSS class assertions
- Add explicit triggerSync() before expecting conflict dialog
This commit is contained in:
Johannes Millan 2026-01-14 16:16:08 +01:00
parent ec32146ac0
commit f31aa0f4a4
2 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

22
e2e/tests/sync/supersync-advanced-edge-cases.spec.ts
View file

@ -48,8 +48,13 @@ test.describe('@supersync SuperSync Advanced Edge Cases', () => {
const taskName = `Bulk${i}-${testRunId}`;
taskNames.push(taskName);
await clientA.workView.addTask(taskName);
// Small settle delay to let UI and NgRx store process each task
await clientA.page.waitForTimeout(100);
}
// Allow operations to fully persist to IndexedDB before sync
await clientA.page.waitForTimeout(500);
// Sync A -> B
await clientA.sync.syncAndWait();
await clientB.sync.syncAndWait();
@ -129,11 +134,16 @@ test.describe('@supersync SuperSync Advanced Edge Cases', () => {
// Mark initial task as done
const initialTaskLocator = clientA.page.locator(`task:has-text("${initialTask}")`);
await initialTaskLocator.hover();
await initialTaskLocator.locator('.task-done-btn').click();
// Wait for done button to be visible after hover reveals it
const doneBtn = initialTaskLocator.locator('.task-done-btn');
await doneBtn.waitFor({ state: 'visible', timeout: 5000 });
await doneBtn.click();
await clientA.sync.syncAndWait();
// Client B "reconnects" (syncs after missing many updates)
await clientB.sync.syncAndWait();
// Extra settle time for state propagation after receiving many operations
await clientB.page.waitForTimeout(500);
// Verify B has all the changes
await waitForTask(clientB.page, offlineTask1);
@ -141,9 +151,13 @@ test.describe('@supersync SuperSync Advanced Edge Cases', () => {
await waitForTask(clientB.page, offlineTask3);
// Initial task should be marked as done
// Use more specific locator to target the done task (avoids matching both backlog and done section)
const initialTaskB = clientB.page.locator(`task.isDone:has-text("${initialTask}")`);
await expect(initialTaskB).toBeVisible();
// Use toPass() to handle Angular change detection lag for CSS class update
await expect(async () => {
const initialTaskB = clientB.page.locator(
`task.isDone:has-text("${initialTask}")`,
);
await expect(initialTaskB).toBeVisible({ timeout: 2000 });
}).toPass({ timeout: 10000, intervals: [500, 1000, 2000] });
console.log('[Stale] Stale client reconnected and received all changes');
} finally {

7
e2e/tests/sync/supersync-import-conflict-dialog.spec.ts
View file

@ -397,8 +397,11 @@ test.describe('@supersync @import-conflict Sync Import Conflict Dialog', () => {
// ============ PHASE 3: Client B Syncs and Chooses CANCEL ============
console.log('[CANCEL] Phase 3: Client B syncs and chooses CANCEL');
// The auto-sync after enabling will trigger the conflict dialog
// Use specific locator for the sync import conflict dialog
// Trigger sync - this will cause the sync import conflict dialog to appear
// (matches the pattern from other tests in this file)
await clientB.sync.triggerSync();
// Wait for the sync import conflict dialog to appear
const dialog = clientB.page.locator('dialog-sync-import-conflict');
await expect(dialog).toBeVisible({ timeout: 15000 });