From ba09f2c440e2340bbe3ff4acb0169e4744ba4d41 Mon Sep 17 00:00:00 2001 From: Johannes Millan Date: Sun, 8 Feb 2026 14:28:21 +0100 Subject: [PATCH] test(focus-mode): fix break resume test to use role selectors after #6000 Banner buttons are now always icon buttons, so use getByRole('button') instead of getByText() to match by aria-label. --- e2e/tests/focus-mode/bug-5995-break-resume.spec.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/e2e/tests/focus-mode/bug-5995-break-resume.spec.ts b/e2e/tests/focus-mode/bug-5995-break-resume.spec.ts index 640dac48b0..dd9620204f 100644 --- a/e2e/tests/focus-mode/bug-5995-break-resume.spec.ts +++ b/e2e/tests/focus-mode/bug-5995-break-resume.spec.ts @@ -107,17 +107,17 @@ test.describe('Bug #5995: Resume paused break (CRITICAL BUG TEST)', () => { console.log('\n=== STEP: About to pause break ==='); // Step 6: Pause the break - const pauseLink = banner.getByText('Pause', { exact: true }); - await expect(pauseLink).toBeVisible({ timeout: 2000 }); - await pauseLink.click(); + const pauseBtn = banner.getByRole('button', { name: 'Pause' }); + await expect(pauseBtn).toBeVisible({ timeout: 2000 }); + await pauseBtn.click(); await page.waitForTimeout(1000); console.log('\n=== STEP: Break paused, about to resume ==='); // Step 7: Resume the break - THIS IS WHERE THE BUG HAPPENS - const resumeLink = banner.getByText('Resume', { exact: true }); - await expect(resumeLink).toBeVisible({ timeout: 2000 }); - await resumeLink.click(); + const resumeBtn = banner.getByRole('button', { name: 'Resume' }); + await expect(resumeBtn).toBeVisible({ timeout: 2000 }); + await resumeBtn.click(); // Wait for state to settle await page.waitForTimeout(2000); @@ -143,7 +143,7 @@ test.describe('Bug #5995: Resume paused break (CRITICAL BUG TEST)', () => { expect(hasSessionText).toBe(false); // Additional verification: Open overlay and check we're on break screen - await banner.getByText('To Focus Overlay').click(); + await banner.getByRole('button', { name: /focus overlay/i }).click(); await page.waitForTimeout(500); const breakScreen = page.locator('focus-mode-break');