Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-07-17 16:37:43 +00:00
Code Issues Projects Releases Wiki Activity

docs(sync): note force-upload as another immutable-snapshot orphan source (#9040)

Browse source 
Document that _uploadSnapshotSplit (USE_LOCAL / recovery) leaves the previous
compaction's immutable snapshot unreferenced, so it joins the crash-window case
as an inert residual leak. Both are reclaimed by the same documented
listFiles-prune backstop. Comment-only.
This commit is contained in:
Johannes Millan 2026-07-15 16:56:47 +02:00
parent 9c5dff3740
commit a855ed2ae5
1 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/app/op-log/sync-providers/file-based/file-based-sync-adapter.service.ts
View file

@ -1471,11 +1471,18 @@ export class FileBasedSyncAdapterService {
* just wrote, which is now an orphan no committed ops file references (the
* concurrent-compaction case that would otherwise leak).
*
* Residual: a crash between the snapshot write and either commit or this cleanup
* still leaks (rare crash window). Upgrade path if it ever matters — an
* opportunistic `listFiles` prune of `STATE_GEN_FILE_PREFIX` files with a stale
* syncVersion (listFiles is optional on the provider interface, so it must stay
* capability-gated).
* Residual leaks these two call sites do NOT cover (all inert — orphaned
* snapshots only waste remote space, never affect correctness):
* - a crash between the snapshot write and either commit or this cleanup;
* - a force-upload (`_uploadSnapshotSplit`: USE_LOCAL / recovery), which resets
* to a fixed `sync-state.json` with a `snapshotRef` carrying no `file`, so the
* previous compaction's immutable snapshot is left unreferenced and the next
* compaction's predecessor-delete (which reads `snapshotRef.file`) can't find
* it.
* Upgrade path if these ever matter — an opportunistic `listFiles` prune that
* deletes every `STATE_GEN_FILE_PREFIX` file except the one the current ops file
* references (listFiles is optional on the provider interface, so it must stay
* capability-gated). That single prune reclaims all of the above.
*/
private async _removeGenStateFile(
provider: FileSyncProvider<SyncProviderId>,