Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-07-18 00:46:45 +00:00
Code Issues Projects Releases Wiki Activity

fix(github-plugin): encode parentheses in search queries (#4913)

Browse source 
encodeURIComponent leaves ( and ) intact per RFC 3986, but GitHub's
search API treats them as grouping operators that must be percent-encoded,
returning HTTP 422 on queries like "(author:@me OR assignee:@me)".

The in-repo provider was fixed in 960330dd56 but the fix didn't carry
over when GitHub moved to a plugin. Reapply via a small encodeGithubQuery
helper used at both call sites.
This commit is contained in:
Johannes Millan 2026-04-21 12:35:12 +02:00
parent 0d5a562aba
commit 7fa03c489e
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
packages/plugin-dev/github-issue-provider/src/plugin.ts
View file

@ -104,6 +104,13 @@ const isAuthOrNotFoundError = (err: unknown): boolean => {
return false;
};
// GitHub's search API requires parentheses percent-encoded, but
// encodeURIComponent leaves them intact (they're unreserved per RFC 3986).
// Unencoded parens cause HTTP 422 on queries like "(author:@me OR assignee:@me)".
// See https://github.com/super-productivity/super-productivity/issues/4913
const encodeGithubQuery = (query: string): string =>
encodeURIComponent(query).replace(/\(/g, '%28').replace(/\)/g, '%29');
PluginAPI.registerIssueProvider({
configFields: [
{
@ -162,7 +169,7 @@ PluginAPI.registerIssueProvider({
const hasTypeFilter =
searchTerm.includes('is:issue') || searchTerm.includes('is:pull-request');
const typeFilter = hasTypeFilter ? '' : ' is:issue';
const q = encodeURIComponent(`repo:${owner}/${repo}${typeFilter} ${searchTerm}`);
const q = encodeGithubQuery(`repo:${owner}/${repo}${typeFilter} ${searchTerm}`);
const url = `${API_BASE}/search/issues?q=${q}&per_page=50`;
const response = await http.get<GithubSearchResponse>(url);
return (response.items || []).map(mapSearchResult);
@ -262,7 +269,7 @@ PluginAPI.registerIssueProvider({
const cfg = config as unknown as GithubConfig;
const { owner, repo } = parseRepo(cfg);
const query = cfg.backlogQuery || 'sort:updated state:open assignee:@me';
const q = encodeURIComponent(`repo:${owner}/${repo} is:issue ${query}`);
const q = encodeGithubQuery(`repo:${owner}/${repo} is:issue ${query}`);
const url = `${API_BASE}/search/issues?q=${q}&per_page=50`;
const response = await http.get<GithubSearchResponse>(url);
return (response.items || []).map(mapSearchResult);