Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-01-23 02:36:05 +00:00
Code Issues Projects Releases Wiki Activity

fix(e2e): use fill() for time input in task-detail tests

Browse source 
The time change tests failed because they computed new hours using
% 24, which produced invalid 12-hour format times (e.g., "13:30 PM").
Use fill() with a fixed valid time instead, following the pattern
from dialog.page.ts.
This commit is contained in:
Johannes Millan 2026-01-06 13:45:30 +01:00
parent 7870c9238e
commit 7d44438620
1 changed files with 10 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

40
e2e/tests/task-detail/task-detail.spec.ts
View file

@ -33,24 +33,14 @@ test.describe('Task detail', () => {
test('should update created with a time change', async ({ page, workViewPage }) => {
await addAndOpenIncompleteTask(workViewPage, page);
const createdInfo = await findDateInfo(page, 'Created');
const createdInfo = findDateInfo(page, 'Created');
const createdInfoText = await createdInfo.textContent();
await createdInfo.click();
const timeInput = await page.getByRole('combobox', { name: 'Time' });
const timeInputText = await timeInput.inputValue();
// Change the hour by adding 1 - works with both 12h and 24h formats
const match = timeInputText!.match(/^(\d+):(\d+)/);
expect(match).toBeTruthy();
const hour = parseInt(match![1], 10);
const newHour = (hour + 1) % 24;
const newTime = timeInputText!.replace(
/^\d+/,
String(newHour).padStart(match![1].length, '0'),
);
await timeInput.clear();
await timeInput.pressSequentially(newTime);
// Press Tab to commit the change before clicking Save
const timeInput = page.getByRole('combobox', { name: 'Time' });
// Use fill() with a fixed valid time - simpler and more reliable than computing relative changes
await timeInput.fill('11:59 PM');
// Blur to trigger form update (ngModelOptions: updateOn: 'blur')
await timeInput.press('Tab');
await page.getByRole('button', { name: 'Save' }).click();
@ -76,24 +66,14 @@ test.describe('Task detail', () => {
test('should update completed with a time change', async ({ page, workViewPage }) => {
await addAndOpenCompleteTask(workViewPage, page);
const completedInfo = await findDateInfo(page, 'Completed');
const completedInfo = findDateInfo(page, 'Completed');
const completedInfoText = await completedInfo.textContent();
await completedInfo.click();
const timeInput = await page.getByRole('combobox', { name: 'Time' });
const timeInputText = await timeInput.inputValue();
// Change the hour by adding 1 - works with both 12h and 24h formats
const match = timeInputText!.match(/^(\d+):(\d+)/);
expect(match).toBeTruthy();
const hour = parseInt(match![1], 10);
const newHour = (hour + 1) % 24;
const newTime = timeInputText!.replace(
/^\d+/,
String(newHour).padStart(match![1].length, '0'),
);
await timeInput.clear();
await timeInput.pressSequentially(newTime);
// Press Tab to commit the change before clicking Save
const timeInput = page.getByRole('combobox', { name: 'Time' });
// Use fill() with a fixed valid time - simpler and more reliable than computing relative changes
await timeInput.fill('11:59 PM');
// Blur to trigger form update (ngModelOptions: updateOn: 'blur')
await timeInput.press('Tab');
await page.getByRole('button', { name: 'Save' }).click();