From 4a7cdcb11aeb6312de459fa8d6d19a9be05330f0 Mon Sep 17 00:00:00 2001 From: Johannes Millan Date: Mon, 12 Aug 2019 22:34:29 +0200 Subject: [PATCH] fix: quick fix to lower case error --- src/app/ui/chip-list-input/chip-list-input.component.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/app/ui/chip-list-input/chip-list-input.component.ts b/src/app/ui/chip-list-input/chip-list-input.component.ts index 6175633bdd..d6344ea199 100644 --- a/src/app/ui/chip-list-input/chip-list-input.component.ts +++ b/src/app/ui/chip-list-input/chip-list-input.component.ts @@ -46,7 +46,7 @@ export class ChipListInputComponent { separatorKeysCodes: number[] = [ENTER, COMMA]; filteredSuggestions: Observable = this.inputCtrl.valueChanges.pipe( - startWith([null]), + startWith(''), map((val: string | null) => val ? this._filter(val) : this.suggestions_.filter(suggestion => !this._modelIds || !this._modelIds.includes(suggestion.id))) @@ -120,9 +120,13 @@ export class ChipListInputComponent { } private _filter(val: string): Suggestion[] { + if (!val || val === null) { + return this.suggestions_; + } + const filterValue = val.toLowerCase(); return this.suggestions_.filter( - suggestion => suggestion.title.toLowerCase().indexOf(filterValue) === 0 + suggestion => suggestion && suggestion.title.toLowerCase().indexOf(filterValue) === 0 && !this._modelIds.includes(suggestion.id) ); }