From 4a50cb35cfe98b129fa73b4044c212dd79457183 Mon Sep 17 00:00:00 2001 From: Johannes Millan Date: Fri, 10 Jan 2025 16:04:29 +0100 Subject: [PATCH] feat: improve language error handling and adjust test --- e2e/commands/noError.ts | 2 ++ src/app/core/language/language.service.ts | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/e2e/commands/noError.ts b/e2e/commands/noError.ts index a8d392e3c..00ac80d51 100644 --- a/e2e/commands/noError.ts +++ b/e2e/commands/noError.ts @@ -6,7 +6,9 @@ module.exports = { browser.getLog('browser', (logEntries) => { const errors = logEntries.filter((entry) => entry.level.name === 'SEVERE'); if (errors.length > 0) { + console.log('\nBROWSER CONSOLE ERRORS:'); console.error(errors); + console.log('\n'); } browser.assert.equal(errors.length, 0, 'No console errors found'); }), diff --git a/src/app/core/language/language.service.ts b/src/app/core/language/language.service.ts index 0e946710a..f7f1a7c97 100644 --- a/src/app/core/language/language.service.ts +++ b/src/app/core/language/language.service.ts @@ -34,7 +34,11 @@ export class LanguageService { if (lng && Object.values(LanguageCode).includes(lng)) { this._setFn(lng); } else { - console.error('Invalid language code', lng); + if (lng) { + console.error('Invalid language code', lng); + } else { + console.warn('No language code provided'); + } this.setFromBrowserLngIfAutoSwitchLng(); } }