From 3d0cfc8698b39b1abbb5301bf2d2e9b994611f00 Mon Sep 17 00:00:00 2001 From: Johannes Millan Date: Sun, 8 Apr 2018 22:16:02 +0200 Subject: [PATCH] fix: change detection parameter for callback for edit on click --- app-src/scripts/edit-on-click/edit-on-click-d.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/app-src/scripts/edit-on-click/edit-on-click-d.js b/app-src/scripts/edit-on-click/edit-on-click-d.js index 944f970390..79838a55fa 100644 --- a/app-src/scripts/edit-on-click/edit-on-click-d.js +++ b/app-src/scripts/edit-on-click/edit-on-click-d.js @@ -81,7 +81,8 @@ } const curVal = el.html(); - const isChanged = lastVal !== curVal; + const isChanged = (lastVal !== curVal); + if (angular.isFunction(scope.editOnClickOnEditFinished)) { scope.editOnClickOnEditFinished({ isChanged, @@ -90,19 +91,14 @@ event, }); } + lastVal = curVal; } function read() { let curVal = el.html(); // strip tags curVal = removeTags(curVal); - - const isChanged = lastVal !== curVal; - - if (isChanged) { - ngModel.$setViewValue(curVal); - lastVal = curVal; - } + ngModel.$setViewValue(curVal); } ngModel.$render = () => {