From 359ddb2d41b9cea9d70dc04528a9baf8975a9fdd Mon Sep 17 00:00:00 2001 From: Johannes Millan Date: Mon, 26 Mar 2018 22:04:26 +0200 Subject: [PATCH] feat: add optional reset break timer but track when tracking on idle dialog --- app-src/scripts/dialogs/was-idle/was-idle-c.html | 11 +++++++++-- app-src/scripts/dialogs/was-idle/was-idle-c.js | 10 ++++++++-- .../main/global-services/take-a-break-reminder-s.js | 6 +++++- 3 files changed, 22 insertions(+), 5 deletions(-) diff --git a/app-src/scripts/dialogs/was-idle/was-idle-c.html b/app-src/scripts/dialogs/was-idle/was-idle-c.html index ee47f7fd2d..05a1f2e636 100644 --- a/app-src/scripts/dialogs/was-idle/was-idle-c.html +++ b/app-src/scripts/dialogs/was-idle/was-idle-c.html @@ -13,7 +13,7 @@ -
+
@@ -32,7 +32,7 @@ + ng-bind="task.title"> No states matching "" were found. @@ -49,6 +49,13 @@ Track + + Track but reset break timer + + diff --git a/app-src/scripts/dialogs/was-idle/was-idle-c.js b/app-src/scripts/dialogs/was-idle/was-idle-c.js index dc81100681..eb2d86242f 100644 --- a/app-src/scripts/dialogs/was-idle/was-idle-c.js +++ b/app-src/scripts/dialogs/was-idle/was-idle-c.js @@ -14,7 +14,7 @@ .controller('WasIdleCtrl', WasIdleCtrl); /* @ngInject */ - function WasIdleCtrl($mdDialog, $rootScope, $scope, Tasks, $window, initialIdleTime, minIdleTimeInMs, theme, $filter, $interval) { + function WasIdleCtrl($mdDialog, $rootScope, $scope, Tasks, $window, initialIdleTime, minIdleTimeInMs, theme, $filter, $interval, TakeABreakReminder) { const POLL_INTERVAL = 1000; let vm = this; @@ -29,7 +29,13 @@ vm.undoneTasks = Tasks.getUndoneToday(true); vm.selectedTask = $rootScope.r.currentTask || $rootScope.r.lastActiveTaskTask || undefined; - vm.trackIdleToTask = () => { + vm.isShowTrackButResetTakeABreakTimer = TakeABreakReminder.isEnabled(); + + vm.trackIdleToTask = (isResetTakeABreakTimer) => { + if (isResetTakeABreakTimer) { + TakeABreakReminder.resetCounter(); + } + if (vm.selectedTask && vm.selectedTask.id) { // add the idle time in milliseconds + the minIdleTime that was // not tracked or removed diff --git a/app-src/scripts/main/global-services/take-a-break-reminder-s.js b/app-src/scripts/main/global-services/take-a-break-reminder-s.js index 7cd87b6377..ef98d17f08 100644 --- a/app-src/scripts/main/global-services/take-a-break-reminder-s.js +++ b/app-src/scripts/main/global-services/take-a-break-reminder-s.js @@ -20,6 +20,10 @@ const TOAST_DISPLAY_TIME = 30000; let toast; + this.isEnabled = () => { + return $rootScope.r.config && $rootScope.r.config.isTakeABreakEnabled; + }; + this.resetCounter = () => { this.lastCounterValBeforeReset = $rootScope.r.currentSession.timeWorkedWithoutBreak; $rootScope.r.currentSession.timeWorkedWithoutBreak = undefined; @@ -43,7 +47,7 @@ }; this.update = (timeSpentInMs, isIdle) => { - if ($rootScope.r.config && $rootScope.r.config.isTakeABreakEnabled) { + if (this.isEnabled()) { if (!$rootScope.r.currentSession) { $rootScope.r.currentSession = {}; }