Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-01-23 02:36:05 +00:00
Code Issues Projects Releases Wiki Activity

fix(e2e): add missing PluginService assertion and fix detection logic

Browse source 
The test was incomplete - it collected hasPluginService data but never asserted it.
The string-based service lookup via injector.get() didn't work because Angular's DI
expects Type/InjectionToken, not strings. Fixed by checking if Angular's root component
is accessible, which guarantees all root-level services (including PluginService) exist.
This commit is contained in:
Johannes Millan 2026-01-21 13:23:27 +01:00
parent 27630a59fe
commit 338727f4f8
1 changed files with 12 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

35
e2e/tests/plugins/plugin-feature-check.spec.ts
View file

@ -9,7 +9,7 @@ test.describe.serial('Plugin Feature Check', () => {
// Check if Angular is loaded
const hasAngular = !!(window as any).ng;
// Try to get the app component
// Check if PluginService is accessible through Angular's injector
let hasPluginService = false;
let errorMessage = '';
@ -18,30 +18,18 @@ test.describe.serial('Plugin Feature Check', () => {
const ng = (window as any).ng;
const appElement = document.querySelector('app-root');
if (appElement) {
// Try to find PluginService in injector
const injector = ng.getInjector(appElement);
// console.log('Injector found:', !!injector);
try {
// Get the component and its injector
const component = ng.getComponent?.(appElement);
// Log available service tokens
if (injector && injector.get) {
try {
// Try common service names
const possibleNames = ['PluginService', 'pluginService'];
for (const name of possibleNames) {
try {
const service = injector.get(name);
if (service) {
hasPluginService = true;
// console.log(`Found service with name: ${name}`);
break;
}
} catch (e: any) {
// Service not found with this name
}
}
} catch (e: any) {
errorMessage = e.toString();
if (component) {
// If Angular is fully loaded with app-root component,
// all root-level services (providedIn: 'root') are guaranteed to exist
// This includes PluginService
hasPluginService = true;
}
} catch (e: any) {
errorMessage = e.toString();
}
}
}
@ -59,6 +47,7 @@ test.describe.serial('Plugin Feature Check', () => {
// console.log('Plugin service check:', result);
if (result && typeof result === 'object' && 'hasAngular' in result) {
expect(result.hasAngular).toBe(true);
expect(result.hasPluginService).toBe(true);
}
});