Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-01-23 02:36:05 +00:00
Code Issues Projects Releases Wiki Activity

fix(offline-banner): only show when cloud features are configured

Browse source 
The offline banner now only appears when the user has cloud sync
(Dropbox, WebDAV, or SuperSync) or enabled issue providers configured.
Users with LocalFile sync and no issue providers will no longer see
the misleading "Syncing will not work" banner when going offline.
This commit is contained in:
Johannes Millan 2026-01-15 19:01:11 +01:00
parent 3f1f961f3a
commit 2ee2d033de
2 changed files with 31 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/app/core/startup/startup.service.spec.ts
View file

@ -16,6 +16,9 @@ import { TrackingReminderService } from '../../features/tracking-reminder/tracki
import { of } from 'rxjs';
import { signal } from '@angular/core';
import { LS } from '../persistence/storage-keys.const';
import { provideMockStore } from '@ngrx/store/testing';
import { selectSyncConfig } from '../../features/config/store/global-config.reducer';
import { selectEnabledIssueProviders } from '../../features/issue/store/issue-provider.selectors';
describe('StartupService', () => {
let service: StartupService;
@ -108,6 +111,12 @@ describe('StartupService', () => {
},
{ provide: ProjectService, useValue: projectServiceSpy },
{ provide: TrackingReminderService, useValue: trackingReminderServiceSpy },
provideMockStore({
selectors: [
{ selector: selectSyncConfig, value: { syncProvider: null } },
{ selector: selectEnabledIssueProviders, value: [] },
],
}),
],
});

25
src/app/core/startup/startup.service.ts
View file

@ -21,7 +21,12 @@ import { isOnline$ } from '../../util/is-online';
import { LS } from '../persistence/storage-keys.const';
import { getDbDateStr } from '../../util/get-db-date-str';
import { DialogPleaseRateComponent } from '../../features/dialog-please-rate/dialog-please-rate.component';
import { take } from 'rxjs/operators';
import { map, take } from 'rxjs/operators';
import { combineLatest } from 'rxjs';
import { Store } from '@ngrx/store';
import { selectSyncConfig } from '../../features/config/store/global-config.reducer';
import { selectEnabledIssueProviders } from '../../features/issue/store/issue-provider.selectors';
import { LegacySyncProvider } from '../../imex/sync/legacy-sync-provider.model';
import { GlobalConfigState } from '../../features/config/global-config.model';
import { IPC } from '../../../../electron/shared-with-frontend/ipc-events.const';
import { IpcRendererEvent } from 'electron';
@ -51,6 +56,7 @@ export class StartupService {
private _projectService = inject(ProjectService);
private _trackingReminderService = inject(TrackingReminderService);
private _opLogStore = inject(OperationLogStoreService);
private _store = inject(Store);
constructor() {
// Initialize electron error handler in an effect
@ -235,8 +241,21 @@ export class StartupService {
}
private _initOfflineBanner(): void {
isOnline$.subscribe((isOnlineIn) => {
if (!isOnlineIn) {
const needsInternet$ = combineLatest([
this._store.select(selectSyncConfig),
this._store.select(selectEnabledIssueProviders),
]).pipe(
map(([syncConfig, enabledIssueProviders]) => {
const hasCloudSync =
syncConfig.syncProvider !== null &&
syncConfig.syncProvider !== LegacySyncProvider.LocalFile;
const hasIssueProviders = enabledIssueProviders.length > 0;
return hasCloudSync || hasIssueProviders;
}),
);
combineLatest([isOnline$, needsInternet$]).subscribe(([isOnline, needsInternet]) => {
if (!isOnline && needsInternet) {
this._bannerService.open({
id: BannerId.Offline,
ico: 'cloud_off',