From 1ca503cb5924d302a114efbd7fe252c1f441bbbf Mon Sep 17 00:00:00 2001
From: Johannes Millan <johannes.millan@gmail.com>
Date: Fri, 1 Aug 2025 12:55:24 +0200
Subject: [PATCH] fix: button only shown if there are any visible projects

Closes #4883
---
 src/app/core-ui/side-nav/side-nav.component.html | 4 ++--
 src/app/core-ui/side-nav/side-nav.component.ts   | 7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/app/core-ui/side-nav/side-nav.component.html b/src/app/core-ui/side-nav/side-nav.component.html
index 32d6f3f08b..461f75a869 100644
--- a/src/app/core-ui/side-nav/side-nav.component.html
+++ b/src/app/core-ui/side-nav/side-nav.component.html
@@ -77,7 +77,7 @@
       <!--      <mat-icon>visibility</mat-icon>-->
       <!--    </button>-->
       <button
-        [style.display]="projectList.length ? '' : 'none'"
+        [style.display]="allNonInboxProjects().length ? '' : 'none'"
         class="additional-btn"
         #projectExpandBtn2
         mat-icon-button
@@ -100,7 +100,7 @@
       [rightClickTriggerEl]="projectExpandBtn"
     ></context-menu>
     <ng-template #contextMenu>
-      @for (project of allNonInboxProjects$ | async; track project.id) {
+      @for (project of allNonInboxProjects(); track project.id) {
         <button
           mat-menu-item
           (click)="toggleProjectVisibility(project)"
diff --git a/src/app/core-ui/side-nav/side-nav.component.ts b/src/app/core-ui/side-nav/side-nav.component.ts
index a67cd1b7c8..5e5f412d0d 100644
--- a/src/app/core-ui/side-nav/side-nav.component.ts
+++ b/src/app/core-ui/side-nav/side-nav.component.ts
@@ -58,6 +58,7 @@ import { TranslatePipe } from '@ngx-translate/core';
 import { AsyncPipe } from '@angular/common';
 import { toggleHideFromMenu } from '../../features/project/store/project.actions';
 import { PluginMenuComponent } from '../../plugins/ui/plugin-menu.component';
+import { toSignal } from '@angular/core/rxjs-interop';
 
 @Component({
   selector: 'side-nav',
@@ -107,9 +108,9 @@ export class SideNavComponent implements OnDestroy {
     this.isProjectsExpanded,
   );
 
-  allNonInboxProjects$: Observable<Project[]> = this._store.select(
-    selectAllProjectsExceptInbox,
-  );
+  allNonInboxProjects = toSignal(this._store.select(selectAllProjectsExceptInbox), {
+    initialValue: [],
+  });
   nonHiddenProjects$: Observable<Project[]> = this.isProjectsExpanded$.pipe(
     switchMap((isExpanded) =>
       isExpanded