Mirrors/proxytunnel
1
0
Fork 0
mirror of https://github.com/proxytunnel/proxytunnel.git synced 2026-01-23 02:34:59 +00:00
Code Issues Projects Releases Wiki Activity

Some more alloca() instead of malloc()

Browse source
This commit is contained in:
Sven Geuer 2023-12-02 21:15:23 +01:00
parent 097a0a2453
commit 5b0e803f25
2 changed files with 4 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

4
basicauth.c
View file

@ -35,7 +35,7 @@ char *basicauth(char *user, char *pass) {
char *b64str = malloc(160);
int len = strlen( user ) + strlen( pass ) + 2;
char *p = (char *) malloc( len );
char *p = (char *) alloca( len );
/* Set up the cookie in clear text */
sprintf( p, "%s:%s", user, pass );
@ -50,8 +50,6 @@ char *basicauth(char *user, char *pass) {
// message( "Proxy basic auth of %s is %s\n", p, basicauth );
// }
free( p );
return b64str;
}

22
ntlm.c
View file

@ -62,11 +62,7 @@ void build_type1() {
ntlm_type1 *type1;
int len = sizeof(ntlm_type1) + sizeof(unsigned char) * TYPE1_DATA_SEG;
type1 = (ntlm_type1 *)malloc(len);
if (!type1) {
message("Fatal Error in build type1, Malloc failed\n");
exit(-1);
}
type1 = (ntlm_type1 *)alloca(len);
memset(type1, 0, len);
type1->signature[0] = 'N';
@ -83,7 +79,6 @@ void build_type1() {
base64((unsigned char *)ntlm_type1_buf, (unsigned char *)type1, len);
free(type1);
return;
}
@ -181,11 +176,7 @@ void build_type3_response() {
len = sizeof(ntlm_type3) + sizeof(unsigned char) * (LM2_DIGEST_LEN + bloblen + (strlen(domain) + strlen(args_info.user_arg) + strlen(workstation)) * sp);
type3 = (ntlm_type3 *)malloc(len);
if (!type3) {
message("Fatal Error in build type3, Malloc failed\n");
exit(-1);
}
type3 = (ntlm_type3 *)alloca(len);
t3 = (unsigned char *) type3;
memset(type3, 0, len);
@ -231,7 +222,6 @@ void build_type3_response() {
base64((unsigned char *)ntlm_type3_buf, (unsigned char *)type3, len);
free(type3);
return;
}
@ -339,12 +329,8 @@ void build_ntlm2_response() {
}
userdomlen = sizeof(unsigned char) * (strlen(args_info.user_arg) + strlen(domain)) * 2;
userdom = (unsigned char *)malloc(userdomlen);
userdom = (unsigned char *)alloca(userdomlen);
memset(userdom, 0, userdomlen);
if (!userdom) {
message("Fatal Error in build_ntlm2_response, Malloc failed\n");
exit(-1);
}
userdomlen = 0;
for (i = 0; i < strlen(args_info.user_arg); i++) {
@ -378,8 +364,6 @@ void build_ntlm2_response() {
hmac_md5(userdom, userdomlen, passdigest, 16, userdomdigest);
free(userdom);
if( args_info.verbose_flag ) {
message("HMAC_MD5 of userdom keyed with MD4 pass is: ");
for( i = 0; i < 16; i++)