Mirrors/photoprism
1
0
Fork 0
mirror of https://github.com/photoprism/photoprism.git synced 2026-07-17 16:49:04 +00:00
Code Issues Projects Releases Wiki Activity

Sidebar: Bind dialog photo prop via $view alias #5505

Browse source
This commit is contained in:
Ömer Duran 2026-04-29 12:37:21 +03:00
parent 7f4b9ad668
commit bedb86536a
No known key found for this signature in database
GPG key ID: 2550B0D579890013
2 changed files with 60 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
frontend/src/component/sidebar/info.vue
View file

@ -609,11 +609,11 @@
</template>
</v-list>
</div>
<p-date-time-dialog :visible="dateTimeDialog" :photo="photo" @close="dateTimeDialog = false" @confirm="confirmDateTime"></p-date-time-dialog>
<p-camera-dialog :visible="cameraDialog" :photo="photo" @close="cameraDialog = false" @confirm="confirmCamera"></p-camera-dialog>
<p-date-time-dialog :visible="dateTimeDialog" :photo="p" @close="dateTimeDialog = false" @confirm="confirmDateTime"></p-date-time-dialog>
<p-camera-dialog :visible="cameraDialog" :photo="p" @close="cameraDialog = false" @confirm="confirmCamera"></p-camera-dialog>
<p-location-dialog
:visible="locationDialog"
:latlng="[photo ? Number(photo.Lat) || 0 : 0, photo ? Number(photo.Lng) || 0 : 0]"
:latlng="[p ? Number(p.Lat) || 0 : 0, p ? Number(p.Lng) || 0 : 0]"
@close="locationDialog = false"
@confirm="confirmLocation"
></p-location-dialog>

57
frontend/tests/vitest/component/sidebar/info.test.js
View file

@ -2553,4 +2553,61 @@ describe("PSidebarInfo component", () => {
expect(w.find(".meta-marker-add").exists()).toBe(false);
});
});
// Pins the template bindings on <p-date-time-dialog>, <p-camera-dialog>,
// and <p-location-dialog>. Commit 7a611b6d6 removed the legacy `photo`
// prop on PSidebarInfo and routed parent state through `$view.getData()`
// (exposed via the `p` computed). The three dialog tags in the sidebar
// template kept referencing the now-undefined `photo` identifier, so the
// dialogs received `:photo="undefined"` / `:latlng="[0, 0]"` and their
// loadFromPhoto() hooks bailed out — opening every sidebar dialog with
// empty inputs even when the photo had values. These tests fail if the
// bindings ever regress to a name that does not exist on the component.
describe("dialog photo prop bindings", () => {
const dialogStubs = {
PDateTimeDialog: { name: "PDateTimeDialog", template: "<div />", props: ["visible", "photo"] },
PCameraDialog: { name: "PCameraDialog", template: "<div />", props: ["visible", "photo"] },
PLocationDialog: { name: "PLocationDialog", template: "<div />", props: ["visible", "latlng"] },
};
function mountWithDialogStubs(photo) {
return mountSidebar({
props: { modelValue: mockModel, photo, canEdit: true, context: contexts.Photos },
global: { stubs: { PMap: true, ...dialogStubs } },
});
}
it("passes the current photo to <p-date-time-dialog>", () => {
const w = mountWithDialogStubs(mockPhoto);
const dialog = w.findComponent({ name: "PDateTimeDialog" });
expect(dialog.exists()).toBe(true);
// Vue 3 wraps `view` (data()) in a reactive proxy, so the dialog
// sees a proxy of mockPhoto rather than the raw reference. A
// deep-equality check still pins the regression: the broken
// binding produced `undefined`, not a structurally-equal proxy.
expect(dialog.props("photo")).toEqual(mockPhoto);
});
it("passes the current photo to <p-camera-dialog>", () => {
const w = mountWithDialogStubs(mockPhoto);
const dialog = w.findComponent({ name: "PCameraDialog" });
expect(dialog.exists()).toBe(true);
expect(dialog.props("photo")).toEqual(mockPhoto);
});
it("derives <p-location-dialog> latlng from the current photo", () => {
const photo = { ...mockPhoto, Lat: 52.52, Lng: 13.405 };
const w = mountWithDialogStubs(photo);
const dialog = w.findComponent({ name: "PLocationDialog" });
expect(dialog.exists()).toBe(true);
expect(dialog.props("latlng")).toEqual([52.52, 13.405]);
});
it("falls back to [0, 0] for <p-location-dialog> when the photo has no coordinates", () => {
const w = mountWithDialogStubs(mockPhoto);
const dialog = w.findComponent({ name: "PLocationDialog" });
expect(dialog.exists()).toBe(true);
expect(dialog.props("latlng")).toEqual([0, 0]);
});
});
});