mirror of
https://github.com/photoprism/photoprism.git
synced 2026-07-17 16:49:04 +00:00
Docs: Clarify NPM_CONFIG_IGNORE_SCRIPTS default and rebuild override
This commit is contained in:
parent
7d39b2d9fe
commit
989227097a
2 changed files with 2 additions and 2 deletions
|
|
@ -17,7 +17,7 @@ Run `make help` to list all available targets. Key commands:
|
|||
|
||||
**Dependencies:**
|
||||
- `make dep` — install all dependencies (TensorFlow models, ONNX models, JS packages)
|
||||
- `make dep-js` — install JS dependencies only (`npm ci`). Prefer `make dep-js` inside the dev container (the `photoprism/develop` base image already ignores install scripts); if you must run npm directly outside it, add `--ignore-scripts` and rebuild only the native addons that need it.
|
||||
- `make dep-js` — install JS dependencies only (`npm ci`). The `photoprism/develop` image and the repo `Makefile` both set `NPM_CONFIG_IGNORE_SCRIPTS=true`, so install scripts are skipped automatically; when running npm directly in an env without that default, pass `--ignore-scripts`. Rebuild native addons with `npm rebuild --ignore-scripts=false <pkg>` — a bare `npm rebuild` no-ops wherever the env default is active.
|
||||
|
||||
**Docker dev environment:**
|
||||
- `make docker-build` — build local Docker image
|
||||
|
|
|
|||
|
|
@ -114,7 +114,7 @@ Title Case rules (Chicago-style, with code- and path-aware normalization):
|
|||
- Bash check: `[ -f "/.dockerenv" ] && echo container || echo host`
|
||||
- Node.js check: `require("fs").existsSync("/.dockerenv")`
|
||||
- Inside the container, prefer `npm exec --yes <agent> -- --help` or `npx <agent> ...`; if a global npm install is unavoidable, install it only inside the container.
|
||||
- The `photoprism/develop` base image sets the npm env to ignore install scripts by default. When running `npm ci` or `npm install` outside that image — e.g. in a coding-agent env that does not inherit it — pass `--ignore-scripts` explicitly to mitigate supply-chain attacks; add a targeted `npm rebuild <pkg>` only if a native addon needs compiling.
|
||||
- The `photoprism/develop` base image and the repo `Makefile` both set `NPM_CONFIG_IGNORE_SCRIPTS=true`, so `npm ci`/`npm install` via `make` targets skip install scripts out of the box. When running npm directly in an environment that does not set or inherit that default, pass `--ignore-scripts` explicitly to mitigate supply-chain attacks. Rebuild native addons with `npm rebuild --ignore-scripts=false <pkg>` — a bare `npm rebuild` is a silent no-op wherever the env default is active.
|
||||
- On the host, use the vendor-recommended install method and run from the repository root so agent discovery sees this file.
|
||||
|
||||
## Build, Format & Test
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue