mirror of
https://github.com/linux-system-roles/network.git
synced 2026-01-23 02:15:17 +00:00
f5ff30a66c
Automation Hub, and possibly Galaxy in the future, require the collection to be screened with `ansible-test sanity` among other checks. The role had a number of issues: * Use `AssertionError` instead of `assert` * Use of `logging` module not in accordance with standards, but these are ok and the errors were suppressed * Several import errors which are ok because they are checked elsewhere * __init__.py in the module_utils directories must be empty, so a new file myerror.py was added to move the code from __init__.py * NOTE: network_lsr/nm/__init__.py is not empty * The documentation block in the module was not properly constructed or formatted. * shellcheck issues, including removing unused files * use `unused` instead of `_` (underscore) for variables that are unused add WARNING to module docs - collection users should not use directly Signed-off-by: Rich Megginson <rmeggins@redhat.com>
62 lines
2.2 KiB
Python
62 lines
2.2 KiB
Python
# SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
|
|
__metaclass__ = type
|
|
|
|
import logging
|
|
|
|
# Relative import is not support by ansible 2.8 yet
|
|
# pylint: disable=import-error, no-name-in-module
|
|
from ansible.module_utils.network_lsr.nm import active_connection # noqa:E501
|
|
from ansible.module_utils.network_lsr.nm import client # noqa:E501
|
|
from ansible.module_utils.network_lsr.nm import connection # noqa:E501
|
|
|
|
# pylint: enable=import-error, no-name-in-module
|
|
|
|
|
|
class NetworkManagerProvider:
|
|
def deactivate_connection(self, connection_name, timeout, check_mode):
|
|
"""
|
|
Return True if changed.
|
|
"""
|
|
nm_client = client.get_client()
|
|
changed = False
|
|
for nm_ac in nm_client.get_active_connections():
|
|
nm_profile = nm_ac.get_connection()
|
|
if nm_profile and nm_profile.get_id() == connection_name:
|
|
changed |= active_connection.deactivate_active_connection(
|
|
nm_ac, timeout, check_mode
|
|
)
|
|
if not changed:
|
|
logging.info("No active connection for %s", connection_name)
|
|
|
|
return changed
|
|
|
|
def volatilize_connection_by_uuid(self, uuid, timeout, check_mode):
|
|
"""
|
|
Mark NM.RemoteConnection as volatile(delete on deactivation) via Update2,
|
|
if not supported, delete the profile.
|
|
|
|
Return True if changed.
|
|
"""
|
|
nm_client = client.get_client()
|
|
changed = False
|
|
for nm_profile in nm_client.get_connections():
|
|
if nm_profile and nm_profile.get_uuid() == uuid:
|
|
if hasattr(nm_profile, "update2"):
|
|
changed |= connection.volatilize_remote_connection(
|
|
nm_profile, timeout, check_mode
|
|
)
|
|
else:
|
|
changed |= connection.delete_remote_connection(
|
|
nm_profile, timeout, check_mode
|
|
)
|
|
if not changed:
|
|
logging.info("No connection with UUID %s to volatilize", uuid)
|
|
|
|
return changed
|
|
|
|
def get_connections(self):
|
|
nm_client = client.get_client()
|
|
return nm_client.get_connections()
|