mirror of
https://github.com/linux-system-roles/network.git
synced 2026-01-23 18:35:13 +00:00
f5ff30a66c
Automation Hub, and possibly Galaxy in the future, require the collection to be screened with `ansible-test sanity` among other checks. The role had a number of issues: * Use `AssertionError` instead of `assert` * Use of `logging` module not in accordance with standards, but these are ok and the errors were suppressed * Several import errors which are ok because they are checked elsewhere * __init__.py in the module_utils directories must be empty, so a new file myerror.py was added to move the code from __init__.py * NOTE: network_lsr/nm/__init__.py is not empty * The documentation block in the module was not properly constructed or formatted. * shellcheck issues, including removing unused files * use `unused` instead of `_` (underscore) for variables that are unused add WARNING to module docs - collection users should not use directly Signed-off-by: Rich Megginson <rmeggins@redhat.com>
119 lines
3.5 KiB
Python
119 lines
3.5 KiB
Python
# SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
# Handle NM.RemoteConnection
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
|
|
__metaclass__ = type
|
|
|
|
import logging
|
|
|
|
# Relative import is not support by ansible 2.8 yet
|
|
# pylint: disable=import-error, no-name-in-module
|
|
from ansible.module_utils.network_lsr.nm import client # noqa:E501
|
|
from ansible.module_utils.network_lsr.nm import error # noqa:E501
|
|
|
|
# pylint: enable=import-error, no-name-in-module
|
|
|
|
|
|
def delete_remote_connection(nm_profile, timeout, check_mode):
|
|
if not nm_profile:
|
|
logging.info("NULL NM.RemoteConnection, no need to delete")
|
|
return False
|
|
|
|
if not check_mode:
|
|
main_loop = client.get_mainloop(timeout)
|
|
user_data = main_loop
|
|
nm_profile.delete_async(
|
|
main_loop.cancellable,
|
|
_nm_profile_delete_call_back,
|
|
user_data,
|
|
)
|
|
logging.debug(
|
|
"Deleting profile %s/%s with timeout %s",
|
|
nm_profile.get_id(),
|
|
nm_profile.get_uuid(),
|
|
timeout,
|
|
)
|
|
main_loop.run()
|
|
return True
|
|
|
|
|
|
def _nm_profile_delete_call_back(nm_profile, result, user_data):
|
|
main_loop = user_data
|
|
if main_loop.is_cancelled:
|
|
return
|
|
|
|
try:
|
|
success = nm_profile.delete_finish(result)
|
|
except Exception as e:
|
|
main_loop.fail(
|
|
error.LsrNetworkNmError(
|
|
"Connection deletion aborted on {id}/{uuid}: error={error}".format(
|
|
id=nm_profile.get_id(), uuid=nm_profile.get_uuid(), error=e
|
|
)
|
|
)
|
|
)
|
|
if success:
|
|
main_loop.quit()
|
|
else:
|
|
main_loop.fail(
|
|
error.LsrNetworkNmError(
|
|
"Connection deletion aborted on {id}/{uuid}: error=unknown".format(
|
|
id=nm_profile.get_id(), uuid=nm_profile.get_uuid()
|
|
)
|
|
)
|
|
)
|
|
|
|
|
|
def volatilize_remote_connection(nm_profile, timeout, check_mode):
|
|
if not nm_profile:
|
|
logging.info("NULL NM.RemoteConnection, no need to volatilize")
|
|
return False
|
|
if not check_mode:
|
|
main_loop = client.get_mainloop(timeout)
|
|
user_data = main_loop
|
|
nm_profile.update2(
|
|
None, # settings
|
|
client.NM.SettingsUpdate2Flags.IN_MEMORY_ONLY
|
|
| client.NM.SettingsUpdate2Flags.VOLATILE,
|
|
None, # args
|
|
main_loop.cancellable,
|
|
_nm_profile_volatile_update2_call_back,
|
|
user_data,
|
|
)
|
|
logging.debug(
|
|
"Volatilizing profile %s/%s with timeout %s",
|
|
nm_profile.get_id(),
|
|
nm_profile.get_uuid(),
|
|
timeout,
|
|
)
|
|
main_loop.run()
|
|
return True
|
|
|
|
|
|
def _nm_profile_volatile_update2_call_back(nm_profile, result, user_data):
|
|
main_loop = user_data
|
|
if main_loop.is_cancelled:
|
|
return
|
|
|
|
try:
|
|
success = nm_profile.update2_finish(result)
|
|
except Exception as e:
|
|
main_loop.fail(
|
|
error.LsrNetworkNmError(
|
|
"Connection volatilize aborted on {id}/{uuid}: error={error}".format(
|
|
id=nm_profile.get_id(), uuid=nm_profile.get_uuid(), error=e
|
|
)
|
|
)
|
|
)
|
|
if success:
|
|
main_loop.quit()
|
|
else:
|
|
main_loop.fail(
|
|
error.LsrNetworkNmError(
|
|
"Connection volatilize aborted on {id}/{uuid}: error=unknown".format(
|
|
id=nm_profile.get_id(), uuid=nm_profile.get_uuid()
|
|
)
|
|
)
|
|
)
|