mirror of
https://github.com/linux-system-roles/network.git
synced 2026-01-23 02:15:17 +00:00
0c590cdf5a
The dependency on `ansible.utils.update_fact` is causing issue with
some users who now must install that collection in order to run
the role, even if they do not care about ostree.
The fix is to stop trying to set `ansible_facts.pkg_mgr`, and instead
force the use of the ostree package manager with the `package:` module
`use:` option. The strategy is - on ostree systems, set the flag
`__$ROLENAME_is_ostree` if the system is an ostree system. The flag
will either be undefined or `false` on non-ostree systems.
Then, change every invocation of the `package:` module like this:
```yaml
- name: Ensure required packages are present
package:
name: "{{ __$ROLENAME_packages }}"
state: present
use: "{{ (__$ROLENAME_is_ostree | d(false)) |
ternary('ansible.posix.rhel_rpm_ostree', omit) }}"
```
This should ensure that the `use:` parameter is not used if the system
is non-ostree. The goal is to make the ostree support as unobtrusive
as possible for non-ostree systems.
The user can also set `__$ROLENAME_is_ostree: true` in the inventory or play
if the user knows that ostree is being used and wants to skip the check.
Or, the user is concerned about the performance hit for ostree detection
on non-ostree systems, and sets `__$ROLENAME_is_ostree: false` to skip
the check.
The flag `__$ROLENAME_is_ostree` can also be used in the role or tests to
include or exclude tasks from being run on ostree systems.
This fix also improves error reporting in the `get_ostree_data.sh` script
when included roles cannot be found.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
217 lines
7.3 KiB
YAML
217 lines
7.3 KiB
YAML
# SPDX-License-Identifier: BSD-3-Clause
|
|
---
|
|
- name: Play for testing ethtool ring settings
|
|
hosts: all
|
|
vars:
|
|
interface: testnic1
|
|
type: veth
|
|
tasks:
|
|
- name: Show playbook name
|
|
debug:
|
|
msg: "this is: playbooks/tests_ethtool_ring.yml"
|
|
tags:
|
|
- always
|
|
|
|
- name: "INIT: Ethtool ring tests"
|
|
debug:
|
|
msg: "##################################################"
|
|
- name: Include the task 'show_interfaces.yml'
|
|
include_tasks: tasks/show_interfaces.yml
|
|
- name: Include the task 'manage_test_interface.yml'
|
|
include_tasks: tasks/manage_test_interface.yml
|
|
vars:
|
|
state: present
|
|
- name: Include the task 'assert_device_present.yml'
|
|
include_tasks: tasks/assert_device_present.yml
|
|
- name: Install ethtool (test dependency)
|
|
package:
|
|
name: ethtool
|
|
state: present
|
|
use: "{{ (__network_is_ostree | d(false)) |
|
|
ternary('ansible.posix.rhel_rpm_ostree', omit) }}"
|
|
|
|
- name: Test ethtool ring settings
|
|
block:
|
|
- name: >-
|
|
TEST: I can create a profile without any ring option.
|
|
debug:
|
|
msg: "##################################################"
|
|
- name: Import network role
|
|
import_role:
|
|
name: linux-system-roles.network
|
|
vars:
|
|
network_connections:
|
|
- name: "{{ interface }}"
|
|
type: ethernet
|
|
state: up
|
|
ip:
|
|
dhcp4: false
|
|
auto6: false
|
|
|
|
- name: Get profile's ring options
|
|
command: nmcli -g ethtool.ring-rx c show {{ interface }}
|
|
register: no_ring_nm
|
|
when:
|
|
- network_provider == "nm"
|
|
changed_when: false
|
|
- name: "ASSERT: The profile does not contain ring options"
|
|
assert:
|
|
that: no_ring_nm.stdout | length == 0
|
|
when:
|
|
- network_provider == "nm"
|
|
- name: Get profile's ring options
|
|
command:
|
|
grep ETHTOOL /etc/sysconfig/network-scripts/ifcfg-{{ interface }}
|
|
register: no_ring_initscripts
|
|
ignore_errors: true
|
|
when:
|
|
- network_provider == "initscripts"
|
|
changed_when: false
|
|
- name: "ASSERT: The profile does not contain ring options"
|
|
assert:
|
|
that: no_ring_initscripts.stdout | length == 0
|
|
when:
|
|
- network_provider == "initscripts"
|
|
|
|
- name: >-
|
|
TEST: I can set rx.
|
|
debug:
|
|
msg: "##################################################"
|
|
- name: Import network role
|
|
import_role:
|
|
name: linux-system-roles.network
|
|
vars:
|
|
network_connections:
|
|
- name: "{{ interface }}"
|
|
type: ethernet
|
|
state: up
|
|
ip:
|
|
dhcp4: false
|
|
auto6: false
|
|
ethtool:
|
|
ring:
|
|
rx: 128
|
|
rx_jumbo: 128
|
|
rx_mini: 128
|
|
tx: 128
|
|
|
|
- name: Get profile's ethtool.ring-rx options
|
|
command: nmcli -g ethtool.ring-rx c show {{ interface }}
|
|
register: with_ring_rx
|
|
when:
|
|
- network_provider == "nm"
|
|
changed_when: false
|
|
- name: Assert ethtool.ring-rx option set in profile
|
|
assert:
|
|
that: with_ring_rx.stdout == '128'
|
|
when:
|
|
- network_provider == "nm"
|
|
- name: Get profile's ethtool.ring-rx-jumbo options
|
|
command: nmcli -g ethtool.ring-rx-jumbo c show {{ interface }}
|
|
register: with_ring_rx_jumbo
|
|
when:
|
|
- network_provider == "nm"
|
|
changed_when: false
|
|
- name: Assert ethtool.ring-rx-jumbo option set in profile
|
|
assert:
|
|
that: with_ring_rx_jumbo.stdout == '128'
|
|
when:
|
|
- network_provider == "nm"
|
|
- name: Get profile's ethtool.ring-rx-mini options
|
|
command: nmcli -g ethtool.ring-rx-mini c show {{ interface }}
|
|
register: with_ring_rx_mini
|
|
when:
|
|
- network_provider == "nm"
|
|
changed_when: false
|
|
- name: Assert ethtool.ring-rx-mini option set in profile
|
|
assert:
|
|
that: with_ring_rx_mini.stdout == '128'
|
|
when:
|
|
- network_provider == "nm"
|
|
- name: Get profile's ethtool.ring-tx options
|
|
command: nmcli -g ethtool.ring-tx c show {{ interface }}
|
|
register: with_ring_tx
|
|
when:
|
|
- network_provider == "nm"
|
|
changed_when: false
|
|
- name: Assert ethtool.ring-tx option set in profile
|
|
assert:
|
|
that: with_ring_tx.stdout == '128'
|
|
when:
|
|
- network_provider == "nm"
|
|
|
|
- name: Get profile's ethtool.ring options
|
|
command:
|
|
grep ETHTOOL /etc/sysconfig/network-scripts/ifcfg-{{ interface }}
|
|
register: with_ring
|
|
ignore_errors: true
|
|
when:
|
|
- network_provider == "initscripts"
|
|
changed_when: false
|
|
- name: Assert ethtool.ring option set in profile
|
|
assert:
|
|
that:
|
|
- '"rx 128" in with_ring.stdout'
|
|
- '"rx-jumbo 128" in with_ring.stdout'
|
|
- '"rx-mini 128" in with_ring.stdout'
|
|
- '"tx 128" in with_ring.stdout'
|
|
when:
|
|
- network_provider == "initscripts"
|
|
|
|
- name: "TEST: I can clear ring options"
|
|
debug:
|
|
msg: "##################################################"
|
|
- name: Import network role
|
|
import_role:
|
|
name: linux-system-roles.network
|
|
vars:
|
|
network_connections:
|
|
- name: "{{ interface }}"
|
|
type: ethernet
|
|
state: up
|
|
ip:
|
|
dhcp4: false
|
|
auto6: false
|
|
|
|
- name: Get profile's ring options
|
|
command: nmcli -g ethtool.ring-rx c show {{ interface }}
|
|
register: clear_ring_nm
|
|
when:
|
|
- network_provider == "nm"
|
|
changed_when: false
|
|
- name: "ASSERT: The profile does reset ring options"
|
|
assert:
|
|
that: clear_ring_nm.stdout | length == 0
|
|
when:
|
|
- network_provider == "nm"
|
|
- name: Get profile's ring options
|
|
command:
|
|
grep ETHTOOL /etc/sysconfig/network-scripts/ifcfg-{{ interface }}
|
|
register: clear_ring_initscripts
|
|
ignore_errors: true
|
|
when:
|
|
- network_provider == "initscripts"
|
|
changed_when: false
|
|
- name: "ASSERT: The profile does reset ring options"
|
|
assert:
|
|
that: clear_ring_initscripts.stdout | length == 0
|
|
when:
|
|
- network_provider == "initscripts"
|
|
|
|
always:
|
|
- name: Clean up the test device and the connection profile
|
|
tags:
|
|
- "tests::cleanup"
|
|
block:
|
|
- name: Import network role
|
|
import_role:
|
|
name: linux-system-roles.network
|
|
vars:
|
|
network_connections:
|
|
- name: "{{ interface }}"
|
|
persistent_state: absent
|
|
failed_when: false
|
|
- name: Include the task 'manage_test_interface.yml'
|
|
include_tasks: tasks/manage_test_interface.yml
|
|
vars:
|
|
state: absent
|