mirror of
https://github.com/linux-system-roles/network.git
synced 2026-07-22 10:37:52 +00:00
ci: Use our own pr_title_lint.py instead of NPM commitlint [citest_skip]
There are a few problems with the NPM commitlint * NPM is problematic * Having to install NPM and commitlint and dependencies is slow and heavyweight * commitlint is overkill for our simple use case We have our own pr_title_lint.py which is small and works exactly for our use case. Enhance coderabbit checks for PRs and test cleanup Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This commit is contained in:
parent
42c0322b17
commit
d4c5353eb0
3 changed files with 40 additions and 147 deletions
8
.github/workflows/pr-title-lint.yml
vendored
8
.github/workflows/pr-title-lint.yml
vendored
|
|
@ -22,11 +22,11 @@ jobs:
|
|||
with:
|
||||
fetch-depth: 0
|
||||
|
||||
- name: Install conventional-commit linter
|
||||
run: npm install @commitlint/config-conventional @commitlint/cli
|
||||
- name: Install pr_title_lint.py
|
||||
run: curl -o pr_title_lint.py https://raw.githubusercontent.com/linux-system-roles/auto-maintenance/main/pr_title_lint.py
|
||||
|
||||
- name: Run commitlint on PR title
|
||||
- name: Run pr_title_lint.py on PR title
|
||||
env:
|
||||
PR_TITLE: ${{ github.event.pull_request.title }}
|
||||
# Echo from env variable to avoid bash errors with extra characters
|
||||
run: echo "$PR_TITLE" | npx commitlint --verbose
|
||||
run: python3 pr_title_lint.py "${PR_TITLE}"
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue