From d311d60b73737646868039a1428cae9d1cd51696 Mon Sep 17 00:00:00 2001 From: Wen Liang Date: Fri, 30 Sep 2022 16:45:33 -0400 Subject: [PATCH] bond: test arp_all_targets only when arp_interval is enabled Kernel allows to set `arp_all_targets` when `arp_interval` is disabled (disable ARP monitoring). But `arp_all_targets` specifies the quantity of `arp_ip_targets` that must be reachable in order for the ARP monitor to consider a slave as being up. It makes more sense to only set the `arp_all_targets` while enabling the `arp_interval`. Signed-off-by: Wen Liang --- examples/bond_options.yml | 1 - tests/playbooks/tests_bond_options.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/examples/bond_options.yml b/examples/bond_options.yml index d236998..297100f 100644 --- a/examples/bond_options.yml +++ b/examples/bond_options.yml @@ -20,7 +20,6 @@ ad_select: stable ad_user_port_key: 1023 all_ports_active: True - arp_all_targets: all downdelay: 0 lacp_rate: slow lp_interval: 128 diff --git a/tests/playbooks/tests_bond_options.yml b/tests/playbooks/tests_bond_options.yml index 4160787..5d00eee 100644 --- a/tests/playbooks/tests_bond_options.yml +++ b/tests/playbooks/tests_bond_options.yml @@ -40,7 +40,6 @@ ad_select: stable ad_user_port_key: 1023 all_ports_active: True - arp_all_targets: all downdelay: 0 lacp_rate: slow lp_interval: 128 @@ -88,7 +87,6 @@ - { key: 'ad_select', value: 'stable'} - { key: 'ad_user_port_key', value: '1023'} - { key: 'all_slaves_active', value: '1'} - - { key: 'arp_all_targets', value: 'all'} - { key: 'downdelay', value: '0'} - { key: 'lacp_rate', value: 'slow'} - { key: 'lp_interval', value: '128'}