Merge pull request #116 from tyll/vlan_mtu_tests_revised

Revise VLAN MTU test

library/network_connections.py

@@ -1349,7 +1349,7 @@ class RunEnvironment:
 class RunEnvironmentAnsible(RunEnvironment):
 
     ARGS = {
-        "ignore_errors": {"required": False, "default": False, "type": "str"},
+        "ignore_errors": {"required": False, "default": False, "type": "bool"},
         "force_state_change": {"required": False, "default": False, "type": "bool"},
         "provider": {"required": True, "default": None, "type": "str"},
         "connections": {"required": False, "default": None, "type": "list"},

tests/playbooks/tests_vlan_mtu.yml

@@ -12,7 +12,9 @@
         state: present
     - include_tasks: tasks/assert-device_present.yml
     - name: "TEST: I can configure the MTU for a vlan interface without autoconnect."
-      import_role:
+      debug:
+        msg: "##################################################"
+    - import_role:
         name: linux-system-roles.network
       vars:
         network_connections:
@@ -45,8 +47,10 @@
         -  "{{ interface }}"
         -  "{{ vlan_interface }}"
 
-    - name: "CLEANUP: remove profiles"
-      import_role:
+    - name: "TEARDOWN: remove profiles."
+      debug:
+        msg: "##################################################"
+    - import_role:
         name: linux-system-roles.network
       vars:
         network_connections:

tests/tests_vlan_mtu_initscripts.yml

@@ -1,12 +1,13 @@
 ---
-# empty playbook to gather facts for import_playbook when clause
+# set network provider and gather facts
 - hosts: all
-  vars:
-    network_provider: initscripts
+  tasks:
+    - name: Set network provider to 'initscripts'
+      set_fact:
+        network_provider: initscripts
 
 # workaround for: https://github.com/ansible/ansible/issues/27973
 # There is no way in Ansible to abort a playbook hosts with specific OS
 # releases Therefore we include the playbook with the tests only if the hosts
 # would support it.
-# The test requires NetworkManager, therefore it cannot run on RHEL 6 or CentOS 6.
 - import_playbook: playbooks/tests_vlan_mtu.yml

tests/tests_vlan_mtu_nm.yml

@@ -1,8 +1,10 @@
 ---
-# empty playbook to gather facts for import_playbook when clause
+# set network provider and gather facts
 - hosts: all
-  vars:
-    network_provider: nm
+  tasks:
+    - name: Set network provider to 'nm'
+      set_fact:
+        network_provider: nm
 
 # workaround for: https://github.com/ansible/ansible/issues/27973
 # There is no way in Ansible to abort a playbook hosts with specific OS