Mirrors/network
1
0
Fork 0
mirror of https://github.com/linux-system-roles/network.git synced 2026-01-23 02:15:17 +00:00
Code Issues Projects Releases Wiki Activity

ansible-lint: Fix ignore-errors failures

Browse source 
In some test playbooks, the `ignore_errors: true` can not be replaced
by `changed_when: false`, because `changed_when` is not a valid
attribute for a IncludeRole.

Signed-off-by: Wen Liang <liangwen12year@gmail.com>
This commit is contained in:
Wen Liang 2023-03-14 19:33:39 -04:00 • committed by Fernando Fernández Mancera
parent 8a3dd3c438
commit 8eed9ae4a9
19 changed files with 25 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/get_coverage.yml
View file

@ -30,7 +30,7 @@
command: "{{ coverage }} combine"
environment:
COVERAGE_FILE: "{{ coverage_file }}"
ignore_errors: true
failed_when: false
changed_when: false
- name: remove old data

2
tests/playbooks/manual_test_ethtool_coalesce.yml
View file

@ -112,7 +112,7 @@
- name: "{{ interface }}"
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- include_tasks: tasks/manage_test_interface.yml
vars:
state: absent

2
tests/playbooks/tests_802_1x.yml
View file

@ -106,7 +106,7 @@
- name: br1
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- include_tasks: tasks/cleanup_802_1x_server.yml
- name: Remove test certificates
file:

4
tests/playbooks/tests_bond.yml
View file

@ -101,9 +101,9 @@
- name: "{{ controller_profile }}"
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- command: ip link del {{ controller_device }}
ignore_errors: true
failed_when: false
- import_tasks: tasks/remove_test_interfaces_with_dhcp.yml
- name: "Restore the /etc/resolv.conf for initscript"
command: mv -vf /etc/resolv.conf.bak /etc/resolv.conf

4
tests/playbooks/tests_bond_cloned_mac.yml
View file

@ -120,9 +120,9 @@
- name: "{{ controller_profile }}"
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- command: ip link del {{ controller_device }}
ignore_errors: true
failed_when: false
- import_tasks: tasks/remove_test_interfaces_with_dhcp.yml
- name: Restore the /etc/resolv.conf for initscript
command: mv -vf /etc/resolv.conf.bak /etc/resolv.conf

4
tests/playbooks/tests_bond_deprecated.yml
View file

@ -97,7 +97,7 @@
- name: "{{ controller_profile }}"
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- command: ip link del {{ controller_device }}
ignore_errors: true
failed_when: false
- import_tasks: tasks/remove_test_interfaces_with_dhcp.yml

4
tests/playbooks/tests_bond_options.yml
View file

@ -188,7 +188,7 @@
- name: "{{ controller_profile }}"
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- command: ip link del {{ controller_device }}
ignore_errors: true
failed_when: false
- import_tasks: tasks/remove_test_interfaces_with_dhcp.yml

4
tests/playbooks/tests_bond_removal.yml
View file

@ -235,9 +235,9 @@
- name: "{{ controller_profile }}"
state: down
persistent_state: absent
ignore_errors: true
failed_when: false
- command: ip link del {{ controller_device }}
ignore_errors: true
failed_when: false
- import_tasks: tasks/remove_test_interfaces_with_dhcp.yml
- name: "Restore the /etc/resolv.conf for initscript"
command: mv -vf /etc/resolv.conf.bak /etc/resolv.conf

2
tests/playbooks/tests_checkpoint_cleanup.yml
View file

@ -74,7 +74,7 @@
always:
- tags:
- "tests::cleanup"
ignore_errors: true
ignore_errors: true # noqa ignore-errors
block:
# Use internal module directly for speedup
- network_connections:

2
tests/playbooks/tests_eth_pci_address_match.yml
View file

@ -75,4 +75,4 @@
- name: pseudo-pci-test-only
persistent_state: absent
state: down
ignore_errors: true
failed_when: false

2
tests/playbooks/tests_ethtool_coalesce.yml
View file

@ -155,7 +155,7 @@
network_connections:
- name: "{{ interface }}"
persistent_state: absent
ignore_errors: true
failed_when: false
- include_tasks: tasks/manage_test_interface.yml
vars:
state: absent

2
tests/playbooks/tests_ethtool_features.yml
View file

@ -202,7 +202,7 @@
- name: "{{ interface }}"
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- include_tasks: tasks/manage_test_interface.yml
vars:
state: absent

2
tests/playbooks/tests_ethtool_ring.yml
View file

@ -193,7 +193,7 @@
network_connections:
- name: "{{ interface }}"
persistent_state: absent
ignore_errors: true
failed_when: false
- include_tasks: tasks/manage_test_interface.yml
vars:
state: absent

4
tests/playbooks/tests_infiniband.yml
View file

@ -76,6 +76,6 @@
- name: ib0-10
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- command: ip link del ib0.000a
ignore_errors: true
failed_when: false

2
tests/playbooks/tests_ipv6_dns_search.yml
View file

@ -156,4 +156,4 @@
- name: br-example
persistent_state: absent
state: down
ignore_errors: true
failed_when: false

2
tests/playbooks/tests_reapply.yml
View file

@ -59,7 +59,7 @@
always:
- tags:
- "tests::cleanup"
ignore_errors: true
ignore_errors: true # noqa ignore-errors
block:
# Use internal module directly for speedup
- network_connections:

2
tests/playbooks/tests_wireless.yml
View file

@ -88,5 +88,5 @@
- name: "{{ interface }}"
persistent_state: absent
state: down
ignore_errors: true
failed_when: false
- include_tasks: tasks/cleanup_mock_wifi.yml

2
tests/tests_change_indication_on_repeat_run.yml
View file

@ -65,7 +65,7 @@
- name: "{{ interface }}"
persistent_state: absent
state: down
ignore_errors: true
ignore_errors: true # noqa ignore-errors
- include_tasks: tasks/manage_test_interface.yml
vars:
state: absent

2
tests/tests_unit.yml
View file

@ -10,7 +10,7 @@
name: "{{ item }}"
state: present
# Ignore error because some package names might not be available
ignore_errors: true
ignore_errors: true # noqa ignore-errors
loop:
- NetworkManager-libnm
- python2-gobject-base