From 89297aa2078a4cfa2d744de4309acb8ac520224e Mon Sep 17 00:00:00 2001
From: Rich Megginson <rmeggins@redhat.com>
Date: Fri, 11 Apr 2025 15:29:12 -0600
Subject: [PATCH] test: set shell to /bin/bash in order to use pipefail

Some of our tests now run on an ubuntu control node (localhost)
and use `shell` to execute commands there.  Ansible requires
the use of `pipefail`.  The default shell on ubuntu is not
bash and does not have `pipefail`.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
---
 tests/tasks/get_modules_and_utils_paths.yml | 80 +++++++++++----------
 1 file changed, 42 insertions(+), 38 deletions(-)

diff --git a/tests/tasks/get_modules_and_utils_paths.yml b/tests/tasks/get_modules_and_utils_paths.yml
index ba855bb..e9bab93 100644
--- a/tests/tasks/get_modules_and_utils_paths.yml
+++ b/tests/tasks/get_modules_and_utils_paths.yml
@@ -40,55 +40,59 @@
 # would translate to tar -C /home/user/.ansible/collections \
 # ansible_collections/fedora/linux_system_roles/plugins/modules
 - name: Find parent directory and path of modules
-  shell: |
-    set -euxo pipefail
-    for dir in {{ modules_search_path | join(" ") }}; do
-      if [ -f "$dir/network_connections.py" ]; then
-        readlink -f "$(dirname "$dir")"
-        basename "$dir"
-        exit 0
-      fi
-    done
-    for dir in {{ collection_paths | join(" ") }}; do
-      if [ ! -d "$dir" ]; then continue; fi
-      cd "$dir"
-      for subdir in ansible_collections/*/*/plugins/modules; do
-        if [ -f "$subdir/network_connections.py" ]; then
-          echo "$dir"
-          echo "$subdir"
+  shell:
+    executable: /bin/bash  # ensure pipefail setting
+    cmd: |
+      set -euxo pipefail
+      for dir in {{ modules_search_path | join(" ") }}; do
+        if [ -f "$dir/network_connections.py" ]; then
+          readlink -f "$(dirname "$dir")"
+          basename "$dir"
           exit 0
         fi
       done
-    done
-    echo network_connections.py not found
-    exit 1
+      for dir in {{ collection_paths | join(" ") }}; do
+        if [ ! -d "$dir" ]; then continue; fi
+        cd "$dir"
+        for subdir in ansible_collections/*/*/plugins/modules; do
+          if [ -f "$subdir/network_connections.py" ]; then
+            echo "$dir"
+            echo "$subdir"
+            exit 0
+          fi
+        done
+      done
+      echo network_connections.py not found
+      exit 1
   delegate_to: localhost
   register: modules_parent_and_dir
   changed_when: false
 
 - name: Find parent directory and path of module_utils
-  shell: |
-    set -euxo pipefail
-    for dir in {{ module_utils_search_path | join(" ") }}; do
-      if [ -d "$dir/network_lsr" ]; then
-        readlink -f "$(dirname "$dir")"
-        basename "$dir"
-        exit 0
-      fi
-    done
-    for dir in {{ collection_paths | join(" ") }}; do
-      if [ ! -d "$dir" ]; then continue; fi
-      cd "$dir"
-      for subdir in ansible_collections/*/*/plugins/module_utils; do
-        if [ -d "$subdir/network_lsr" ]; then
-          echo "$dir"
-          echo "$subdir"
+  shell:
+    executable: /bin/bash  # ensure pipefail setting
+    cmd: |
+      set -euxo pipefail
+      for dir in {{ module_utils_search_path | join(" ") }}; do
+        if [ -d "$dir/network_lsr" ]; then
+          readlink -f "$(dirname "$dir")"
+          basename "$dir"
           exit 0
         fi
       done
-    done
-    echo network_lsr not found
-    exit 1
+      for dir in {{ collection_paths | join(" ") }}; do
+        if [ ! -d "$dir" ]; then continue; fi
+        cd "$dir"
+        for subdir in ansible_collections/*/*/plugins/module_utils; do
+          if [ -d "$subdir/network_lsr" ]; then
+            echo "$dir"
+            echo "$subdir"
+            exit 0
+          fi
+        done
+      done
+      echo network_lsr not found
+      exit 1
   delegate_to: localhost
   register: module_utils_parent_and_dir
   changed_when: false