From 38fa6f1033b9ef27ab2e3a6f79d7f8f37fc8087f Mon Sep 17 00:00:00 2001 From: OPOLKA Alexis OF/DSI Date: Thu, 26 Feb 2026 12:21:19 +0100 Subject: [PATCH] feat: Update the current integration tests to ignore the tldr integration The current tldr-pages integration is too flaky and doesn't represent a mature/robust way of interacting with the tldr project, the integration tests have been disabled until we develop a robust way of interacting with the project Signed-off-by: OPOLKA Alexis OF/DSI --- .github/workflows/ci.yml | 2 +- src/clients/tldr.rs | 2 +- tests/run | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5bc3566..4c0af4b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,7 +72,7 @@ jobs: - name: Install fzf run: git clone --depth 1 https://github.com/junegunn/fzf.git ~/.fzf; yes | ~/.fzf/install; - - name: Install tealdeer + - name: Install the official tldr client run: sudo npm install -g tldr - name: Run bash tests diff --git a/src/clients/tldr.rs b/src/clients/tldr.rs index 97c2b9b..c9929a1 100644 --- a/src/clients/tldr.rs +++ b/src/clients/tldr.rs @@ -68,7 +68,7 @@ pub fn call(query: &str) -> Result> { Ok(x) => x, Err(_) => { let msg = format!( - "navi was unable to call tldr. + "navi was unable to call the tldr client. Make sure tldr is correctly installed. Note: diff --git a/tests/run b/tests/run index 3d57135..cc8527f 100755 --- a/tests/run +++ b/tests/run @@ -162,9 +162,12 @@ test::run "elvish" _navi_widget "elvish" test::run "nu" _navi_widget "nushell" test::set_suite "3rd party" -test::run "tldr" _navi_tldr test::run "cheatsh" _navi_cheatsh +## Disabled test under further work is done to re-establish a correct integration with the tdlr-pages +## project. +# test::run "tldr" _navi_tldr + test::set_suite "integration" test::run "welcome->pwd" _integration