miller/internal/pkg/transformers/decimate.go
Stephen Kitt d536318ed6
Use int64 wherever "64-bit integer" is assumed (#902)
Miller assumes 64-bit integers, but in Go, the int type varies in size
depending on the architecture: 32-bit architectures have int
equivalent to int32. As a result, the supported range of integer
values is greatly reduced on 32-bit architectures compared to what is
suggested by the documentation.

This patch explicitly uses int64 wherever 64-bit integers are
assumed.

Test cases affected by the behaviour of the random generator are
updated to reflect the new values (the existing seed doesn't produce
the same behaviour since the way random values are generated has
changed).

Signed-off-by: Stephen Kitt <steve@sk2.org>
2022-01-27 12:06:25 -05:00

178 lines
4.4 KiB
Go

package transformers
import (
"container/list"
"fmt"
"os"
"strings"
"github.com/johnkerl/miller/internal/pkg/cli"
"github.com/johnkerl/miller/internal/pkg/types"
)
// ----------------------------------------------------------------
const verbNameDecimate = "decimate"
var DecimateSetup = TransformerSetup{
Verb: verbNameDecimate,
UsageFunc: transformerDecimateUsage,
ParseCLIFunc: transformerDecimateParseCLI,
IgnoresInput: false,
}
func transformerDecimateUsage(
o *os.File,
doExit bool,
exitCode int,
) {
fmt.Fprintf(o, "Usage: %s %s [options]\n", "mlr", verbNameDecimate)
fmt.Fprintf(o, "Passes through one of every n records, optionally by category.\n")
fmt.Fprintf(o, "Options:\n")
fmt.Fprintf(o, " -b Decimate by printing first of every n.\n")
fmt.Fprintf(o, " -e Decimate by printing last of every n (default).\n")
fmt.Fprintf(o, " -g {a,b,c} Optional group-by-field names for decimate counts, e.g. a,b,c.\n")
fmt.Fprintf(o, " -n {n} Decimation factor (default 10).\n")
fmt.Fprintf(o, "-h|--help Show this message.\n")
if doExit {
os.Exit(exitCode)
}
}
func transformerDecimateParseCLI(
pargi *int,
argc int,
args []string,
_ *cli.TOptions,
doConstruct bool, // false for first pass of CLI-parse, true for second pass
) IRecordTransformer {
// Skip the verb name from the current spot in the mlr command line
argi := *pargi
verb := args[argi]
argi++
decimateCount := int64(10)
atStart := false
atEnd := false
var groupByFieldNames []string = nil
for argi < argc /* variable increment: 1 or 2 depending on flag */ {
opt := args[argi]
if !strings.HasPrefix(opt, "-") {
break // No more flag options to process
}
if args[argi] == "--" {
break // All transformers must do this so main-flags can follow verb-flags
}
argi++
if opt == "-h" || opt == "--help" {
transformerDecimateUsage(os.Stdout, true, 0)
} else if opt == "-n" {
decimateCount = cli.VerbGetIntArgOrDie(verb, opt, args, &argi, argc)
if decimateCount <= 0 {
transformerDecimateUsage(os.Stderr, true, 1)
}
} else if opt == "-b" {
atStart = true
} else if opt == "-e" {
atEnd = true
} else if opt == "-g" {
groupByFieldNames = cli.VerbGetStringArrayArgOrDie(verb, opt, args, &argi, argc)
} else {
transformerDecimateUsage(os.Stderr, true, 1)
}
}
*pargi = argi
if !doConstruct { // All transformers must do this for main command-line parsing
return nil
}
transformer, err := NewTransformerDecimate(
decimateCount,
atStart,
atEnd,
groupByFieldNames,
)
if err != nil {
fmt.Fprintln(os.Stderr, err)
os.Exit(1)
}
return transformer
}
// ----------------------------------------------------------------
type TransformerDecimate struct {
decimateCount int64
remainderToKeep int64
groupByFieldNames []string
countsByGroup map[string]int64
}
// ----------------------------------------------------------------
func NewTransformerDecimate(
decimateCount int64,
atStart bool,
atEnd bool,
groupByFieldNames []string,
) (*TransformerDecimate, error) {
remainderToKeep := decimateCount - 1
if atStart && !atEnd {
remainderToKeep = 0
}
tr := &TransformerDecimate{
decimateCount: decimateCount,
remainderToKeep: remainderToKeep,
groupByFieldNames: groupByFieldNames,
countsByGroup: make(map[string]int64),
}
return tr, nil
}
// ----------------------------------------------------------------
func (tr *TransformerDecimate) Transform(
inrecAndContext *types.RecordAndContext,
outputRecordsAndContexts *list.List, // list of *types.RecordAndContext
inputDownstreamDoneChannel <-chan bool,
outputDownstreamDoneChannel chan<- bool,
) {
HandleDefaultDownstreamDone(inputDownstreamDoneChannel, outputDownstreamDoneChannel)
if !inrecAndContext.EndOfStream {
inrec := inrecAndContext.Record
groupingKey, ok := inrec.GetSelectedValuesJoined(tr.groupByFieldNames)
if !ok {
return // This particular record doesn't have the specified fields; ignore
}
countForGroup, ok := tr.countsByGroup[groupingKey]
if !ok {
countForGroup = 0
tr.countsByGroup[groupingKey] = countForGroup
}
remainder := countForGroup % tr.decimateCount
if remainder == tr.remainderToKeep {
outputRecordsAndContexts.PushBack(inrecAndContext)
}
countForGroup++
tr.countsByGroup[groupingKey] = countForGroup
} else {
outputRecordsAndContexts.PushBack(inrecAndContext) // Emit the stream-terminating null record
}
}