miller/test
John Kerl a723f6cdaa
Fix PPRINT alignment with multi-character OFS (#1819) (#2063)
* Fix column alignment for wide and combining Unicode chars (#1520, #379)

PPRINT, markdown-aligned, and XTAB writers measured column widths with
utf8.RuneCountInString, which counts codepoints rather than terminal
display columns. East-Asian fullwidth characters (counted as 1 but
displayed as 2) and zero-width combining marks (counted as 1 but
displayed as 0) both caused misalignment.

Add lib.DisplayWidth wrapping uniseg.StringWidth, and use it from the
three writers. The XTAB right-aligned path also drops fmt.Sprintf with
%*s since Go's %*s pads by rune count too.

UTF8Strlen is unchanged so DSL strlen semantics are preserved.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix PPRINT alignment with multi-character OFS (#1819)

Previously, writePadding repeated the OFS string for each padding slot, so
non-space or multi-character OFS values produced misaligned columns and
leaked the separator into padding (e.g. --ofs=XY yielded aXYXYXYXYb).

Pad with spaces instead, leaving OFS to act only as the column separator.
The default single-space OFS is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Use non-space multi-char OFS in test 0021 for Windows portability

PowerShell collapses single-quoted '  ' in command lines, which broke
the test on the windows-latest CI runner. Switch to --ofs XY, which
exercises the same multi-character padding code path without shell
quoting hazards.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-17 12:45:49 -04:00
..
cases Fix PPRINT alignment with multi-character OFS (#1819) (#2063) 2026-05-17 12:45:49 -04:00
cases-not-suitable-for-ci Avoid assuming ./mlr is the mlr to test (#876) 2022-01-17 17:01:40 -05:00
expected Standardize Go-package structure (#746) 2021-11-11 14:15:13 -05:00
input Apply join prefixes/rename to unpaired records (#1821) (#2062) 2026-05-17 12:35:58 -04:00
stdlib Standardize Go-package structure (#746) 2021-11-11 14:15:13 -05:00
README.md test/README.md (#1972) 2026-02-16 16:44:31 -05:00

Miller regression tests

There are a few files unit-tested with Go's testing package -- a few dozen cases total.

The vast majority of Miller tests, though -- thousands of cases -- are tested by running scripted invocations of mlr with various flags and inputs, comparing against expected output, and checking the exit code back to the shell.

How to run the regression tests, in brief

Note: while this README.md file is within the test/ subdirectory, all paths in this file are written from the perspective of the user being cd'ed into the repository base directory, i.e. this directory's parent directory.

  • mlr regtest --help

  • go test github.com/johnkerl/miller/v6/pkg/... — runs the Go unit tests (a few dozen cases).

Items for the duration of the Go port

  • mlr regtest -c ... runs the C version of Miller from the local checkout

More details

You can alias mr='mlr regtest' for convenience. With no arguments, mr runs all cases under test/cases/. Pass one or more paths to run only those directories or specific .cmd files.

  • mr — run all regression cases (default path is test/cases/).
  • mr test/cases/foo — run only cases under that directory.
  • mr -v test/cases/foo — same, plus per-command pass/fail; use -vv or -vvv for more detail.
  • mr -j test/cases/foo/0003 — show the Miller command, any script, and actual output for that case (handy for debugging).
  • mr -p test/cases/foo/0003populate: write or overwrite expout and experr from the current run (use when adding or updating expected output).
  • mr -c ... — use the C build of Miller (e.g. -c../c/mlr) instead of the current executable.

To review populated files before committing, run mr -p on the desired path, then git diff to inspect changes and git reset --hard to discard them.

Creating new cases

  1. Create a case directory under test/cases/, e.g. test/cases/my-feature/0001.
  2. Add a cmd file containing the Miller command line (one line), e.g. mlr cat test/input/simple.dkvp.
  3. Use shared input under test/input/, or add a local input file in the case directory; in cmd you can use ${CASEDIR} so the command refers to the case directory (e.g. mlr cat ${CASEDIR}/input).
  4. Run mlr regtest -p test/cases/my-feature/0001 to generate expout (and experr if the command produces stderr). If the command is expected to exit non-zero, add an empty should-fail file.
  5. Run mlr regtest test/cases/my-feature/0001 (without -p) to confirm the case passes.

Optional: mlr — DSL script file when the test uses -f/put/filter; env — environment variables to set for the case (unset after).