mirror of
https://github.com/johnkerl/miller.git
synced 2026-07-17 16:38:54 +00:00
78363f1cc3
The DKVPX record reader set dkvpxReader.Comma = ',' unconditionally,
ignoring the resolved --ifs value; the key-value separator '=' was
likewise hard-coded in the dkvpx parser, ignoring --ips. So e.g.
printf 'a=1;b=2\n' | mlr -i dkvpx --ifs semicolon --ojson cat
produced a single field {"a": "1;b=2"} instead of {"a": 1, "b": 2}.
Fixes:
* pkg/dkvpx.Reader gains an Equals field (default '=') alongside Comma.
* The DKVPX record reader now passes the resolved IFS/IPS through,
validating that each is a single character (mirroring the CSV
reader's "IFS can only be a single character" error) rather than
silently ignoring or truncating them.
* The DKVPX record writer already emitted OFS/OPS, but its quoting
decisions were based on the default separators, so with --ofs
semicolon a value containing ';' went out unquoted (ambiguous) while
a value containing ',' was quoted needlessly. Quoting now keys off
the actual OFS/OPS.
Adds unit tests, regression cases under test/cases/io-dkvpx/, and a
note in the separators reference table.
Discovered while investigating #369; tracked in #2170.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| channel_writer.go | ||
| doc.go | ||
| file_output_handlers.go | ||
| README.md | ||
| record_writer.go | ||
| record_writer_csv.go | ||
| record_writer_csv_colorizer.go | ||
| record_writer_csv_test.go | ||
| record_writer_csvlite.go | ||
| record_writer_dcf.go | ||
| record_writer_dkvp.go | ||
| record_writer_dkvpx.go | ||
| record_writer_factory.go | ||
| record_writer_json_jsonl.go | ||
| record_writer_markdown.go | ||
| record_writer_nidx.go | ||
| record_writer_pprint.go | ||
| record_writer_tsv.go | ||
| record_writer_xtab.go | ||
| record_writer_yaml.go | ||
Logic for formatting output records as strings to standard output.
There is one record-writer type per supported output file format, and a factory method.